sort-conversations-by-update-time - Restore trailing space in query#9359
Merged
Conversation
…tions-by-update-time Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/c8b12867-da78-4487-a746-631aa57eb8f3 Co-authored-by: fregante <[email protected]>
fregante
approved these changes
May 7, 2026
Member
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
I suppose this makes sense. My guess is that the change happened on GitHub's side, where they'd automatically append a space to the query even if it wasn't there, but they no longer do that.
fregante
changed the title
sort-conversations-by-update-time - Restore trailing space in query
fregante
reviewed
May 7, 2026
| get href(): string { | ||
| this.url.searchParams.set('q', this.get()); | ||
| const query = this.get(); | ||
| this.url.searchParams.set('q', this.trailingSpace ? query + ' ' : query); |
Member
There was a problem hiding this comment.
- This shouldn't be optional. The space should always be included in the
href - add tests
- also add tests to see the behavior with queries with multiple leading and trailing spaces, as well as between queries. The trailing and leading spaces should be dropped
Contributor
Author
There was a problem hiding this comment.
Done in 8afe64d — href now always appends a trailing space unconditionally (removed the trailingSpace flag). Added tests for:
hrefalways ends with+hrefalways ends with+afterprepend()- Multiple leading spaces dropped from
get() - Multiple trailing spaces dropped from
get() - Multiple spaces between terms collapsed in
get()
…on tests Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/392b7e89-144a-4641-a09d-2eb65a25200b Co-authored-by: fregante <[email protected]>
…ersations-space-issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sort-conversations-by-update-timeis dropping a space #9355Test URLs
Screenshot
See the trailing
+