clear-pr-merge-commit-message - Add Undo button#9337
Merged
fregante merged 8 commits intoMay 2, 2026
Merged
Conversation
agriyakhetarpal
changed the title
fregante
reviewed
May 2, 2026
Member
|
Looks great already, btw. These are just code nits |
- Link "Cleared" instead of "Refined GitHub" - Add btn-link class to button - Don't use an inline listener - Inline the link via event.currentTarget Co-Authored-By: Federico <[email protected]>
Contributor
Author
|
Thank you, I appreciate the suggestions! I incorporated all of them, though I think you meant the |
fregante
changed the title
clear-pr-merge-commit-message - Add Undo button
SunsetTechuila
approved these changes
May 2, 2026
fregante
reviewed
May 2, 2026
Now it is close enough to the first one
fregante
approved these changes
May 2, 2026
agriyakhetarpal
deleted the
undo-and-redo-for-clearing-pr-merge-time-commit-messages
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the second part of and closes #9330. I have added an "Undo"/"Redo" toggle link to the note next to the merge-time message about PR commit descriptions. It is a link element that mutates between two states.
Test URLs
Tested on a test PR on my own repository here: agriyakhetarpal/agriyakhetarpal#1
I haven't added any test code for this; I'm not sure how to do so, and if there's a practical way. The clearing logic is already tested, and undo/redo is roughly two lines of state, which probably isn't worth testing on its own.
Screenshot
I have a screen recording, if that helps!
Screen.Recording.2026-05-02.at.03.55.47.mov
Thank you :)