clean-pinned-issues - Native alignment#9313
Conversation
This is a downgrade because the space is used far less efficiently
Issue title is more important than its metadata, so we absolutely shouldn't prefer wrapping it over the metadata. Especially considering that it cannot go under the metadata when wrapped |
|
If you like the way native vertical issues look, then why not just make them always enabled? This will simplify the feature a lot |
|
This could be the entire feature: div[class^='IssueIndexPage-module__middlePaneGrid'] {
container-type: inline-size;
/* Element whose width is tracked */
> div:not([class]) {
max-width: 767px; /* Enable native vertical sorting */
}
}
ul[aria-label="Drag and drop pinned issues list."] {
flex-direction: column !important;
width: 100cqw; /* Restore original width */
row-gap: 0;
}
[class*="PinnedIssues-module__container"] {
max-width: 100% !important;
&:not(:only-child) {
&:first-child {
border-bottom-left-radius: 0;
border-bottom-right-radius: 0;
}
&:not(:first-child, :last-child) {
border-radius: 0;
border-top-color: transparent;
}
&:last-child {
border-top-color: transparent;
border-top-left-radius: 0;
border-top-right-radius: 0;
}
}
} |
Not an upgrade:
If you look around GitHub, the style is everywhere. This is currently in my viewport alone: It's so common even MDN has a page for it: https://developer.mozilla.org/en-US/docs/Web/CSS/How_to/Layout_cookbook/Media_objects
Agreed, I was trying to find ways to make it look more consistent, but neither proposal is ideal.
I think it is possible via
I only used it as an example of where the button should appear—which is also where it appears in several other GitHub components:
It does look good, but it's also twice as tall on desktop. |











Follows #9284 (comment)
Test URLs
https://github.com/refined-github/sandbox/issues
Native
Notice the
...top-aligned#9284
This PR
Also notice the title not wrapping below the left-hand icon
Further proposals
I'd go one step further and avoid wrapping the right-hand text
or _always_ wrap it, but it looks weird sometimes