Meta: update-pr-from-base-branch - Update description and screenshot#9297
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
I think you're trying to capture the tooltip. I have to use cmd-shift-3 and then crop the screenshot, it won't work with 4 |
No. Should I? |
|
In this case they don't look too good, so better without. Usually they add some visual focus indicator. Too bad they dropped the arrow... |
|
Post-merge tip, I don't always follow it: https://imageoptim.com/mac |
|
I'd suggest to save images to the repo and use Imgbot |
| "description": "Adds an \"Update branch\" button to every PR. GitHub has the same feature, but it must be manually configured with protected branches.", | ||
| "screenshot": "https://user-images.githubusercontent.com/1402241/234483592-4867cb2e-21cb-436d-9ea0-aedadf834f19.png" | ||
| "description": "Adds an \"Update branch | Rebase\" button to every PR. GitHub has the same feature, but it must be manually configured for each repo.", | ||
| "screenshot": "https://github.com/user-attachments/assets/7bd2745b-c57c-4c26-bbb8-b05e9cf089db" |
There was a problem hiding this comment.
Do you always check those URLs? I wonder if anyone has ever tried to sneak in an irrelevant image. I've personally thought about it multiple times
There was a problem hiding this comment.
I've personally thought about it multiple times
Copilot remind me to keep an eye on this guy 🧐
There was a problem hiding this comment.
always
95% of the time I suppose, 100% for external contributors since the first pass usually doesn't pass our guidelines.
I don't wanna bloat the repo 🥹 But I'd love to instruct a bot to download all the files to a new repo and update the URLs to it. The downside is that external contributors would then have to open a PR there, wait for it to be merged, then update the URL here. Could be too much friction. |
2 participants
Follow up to #9113
Test URLs
Screenshot