Skip to content

clean-pinned-issues - Fix sorting and options button position#9284

Merged
SunsetTechuila merged 18 commits into
mainfrom
clean-pin
Apr 26, 2026
Merged

clean-pinned-issues - Fix sorting and options button position#9284
SunsetTechuila merged 18 commits into
mainfrom
clean-pin

Conversation

@SunsetTechuila
Copy link
Copy Markdown
Member

@SunsetTechuila SunsetTechuila commented Apr 26, 2026

Comment thread source/features/clean-pinned-issues.css Outdated
margin: 0;

/* Rounded table border https://stackoverflow.com/a/2586780/288906 */
box-shadow: 0 0 0 1px var(--rgh-border-outer-color, fuchsia);
Copy link
Copy Markdown
Member Author

@SunsetTechuila SunsetTechuila Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before image
After image

@fregante
Copy link
Copy Markdown
Member

Looks great! I'd go a bit further and drop like 4px of padding on the left and 2px on the right. Something like that

@fregante
Copy link
Copy Markdown
Member

Wait

@fregante
Copy link
Copy Markdown
Member

fregante commented Apr 26, 2026

image

Can you check how they wrap on tighter viewports? This is the previous version, which is kinda wonky. The ... button is not aligned to the text (rather, the text should be top-aligned too) and the PR title wraps under the green status icon.

@SunsetTechuila
Copy link
Copy Markdown
Member Author

Looks great! I'd go a bit further and drop like 4px of padding on the left and 2px on the right. Something like that

image

@SunsetTechuila
Copy link
Copy Markdown
Member Author

Can you check how they wrap on tighter viewports?

chrome_a20mFTQl7A

@SunsetTechuila
Copy link
Copy Markdown
Member Author

I think we should align text to the end

image

@SunsetTechuila
Copy link
Copy Markdown
Member Author

image

@SunsetTechuila SunsetTechuila merged commit dd7b9a5 into main Apr 26, 2026
10 checks passed
@SunsetTechuila SunsetTechuila deleted the clean-pin branch April 26, 2026 20:24
@fregante
Copy link
Copy Markdown
Member

I said it before: content should be top aligned, not centered.

Try resizing the window so the left side wrap and the right side doesn't. Search baseline alignment

@SunsetTechuila
Copy link
Copy Markdown
Member Author

SunsetTechuila commented Apr 27, 2026

I said it before: content should be top aligned, not centered.

Is this what you want?

image

This is just straight up very ugly. I won't implement it

Try resizing the window so the left side wrap and the right side doesn't.

This never happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

clean-pinned-issues breaks sorting clean-pinned-issues has weird icon

2 participants