Meta: Add `eslint/css` by Copilot · Pull Request #9275 · refined-github/refined-github

Copilot · 2026-04-25T09:44:28Z

Adds @eslint/css to lint all *.css files in the project.

Config changes (`eslint.config.js`)

Import @eslint/css and add it as a CSS language plugin for **/*.css
tolerant: true — required to parse modern CSS features (@container range syntax, nesting, etc.) without errors
css/no-important: 'off' — !important is intentionally used throughout to override GitHub's styles
css/use-baseline: 'off' — we support the latest browsers only
css/no-invalid-properties: 'off' — Bug: css/no-invalid-properties can't parse valid nested color functions eslint/css#434
css/font-family-fallbacks: 'off' — GitHub-defined font stacks may not have generic fallbacks
Disable all svelte/* rules for **/*.css files — Svelte rules require the Svelte parser and crash when applied to CSS files

CSS fixes

File	Change
`clean-conversation-sidebar.css`	Change bare `span:is(...)` nested selector to `& span:is(...)` — corrects CSS nesting spec compliance (bare type selectors require `&`)
`clean-rich-text-editor.css`	Replace deprecated `clip: rect(...)` with `clip-path: inset(50%)`
`readable-title-change-events.css`	Replace non-standard `word-break: break-word` with standard `overflow-wrap: break-word`
`show-associated-branch-prs-on-fork.css`	Expand `font: 600 12px / 1 inherit` shorthand into individual `font-weight`, `font-size`, `line-height`, and `font-family` properties

Test URLs

Screenshot

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/749e024f-1667-4032-9fc6-7f3f6dc1da83 Co-authored-by: fregante <[email protected]>

fregante

A couple of good suggestions but otherwise noise and bugs. We can reconsider if we decide to introduce custom CSS lint rules.

fregante · 2026-04-30T07:28:32Z

Yes there's room for custom rules, for example to avoid #9298

Let's add it, even if it means disabling most native rules.

fregante · 2026-04-30T07:30:04Z

@copilot disable css/use-baseline, undo the changes in show-associated-branch-prs-on-fork.css, remove all inline css/no-invalid-properties exclusions and let the lint script fail, I want to see the error

…o-invalid-properties exclusions Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/d5e8e282-de39-44b4-9163-14e23bdda5f5 Co-authored-by: fregante <[email protected]>

Copilot · 2026-04-30T07:33:47Z

@copilot disable css/use-baseline, undo the changes in show-associated-branch-prs-on-fork.css, remove all inline css/no-invalid-properties exclusions and let the lint script fail, I want to se...

Done in 247f827:

css/use-baseline disabled globally in the config
show-associated-branch-prs-on-fork.css reverted to original (font: 600 12px / 1 inherit)
All inline css/no-invalid-properties exclusions removed (heat-map.css, sticky-comment-header.css)

The failing lint now shows 13 errors across 3 files:

show-associated-branch-prs-on-fork.css: invalid font shorthand + missing font fallbacks
sticky-comment-header.css: linear-gradient(var(…), var(…)) parsed as invalid background value
heat-map.css (×10): color-mix(…, var(--fgColor-muted, var(--fallback))) — the nested var() fallback confuses the parser into reading ) as the color value

fregante · 2026-04-30T08:28:47Z

@copilot merge conflicts, disable css/no-invalid-properties and css/font-family-fallbacks globally, explain why you're using tolerant. Then run npm run fix before committing.

…lbacks globally, explain tolerant Co-authored-by: fregante <[email protected]>

Copilot · 2026-04-30T08:32:53Z

@copilot merge conflicts, disable css/no-invalid-properties and css/font-family-fallbacks globally, explain why you're using tolerant. Then run npm run fix before committing.

Done in 6f1d7e1:

Merged origin/main
css/no-invalid-properties and css/font-family-fallbacks both disabled globally (off)
Added a comment on tolerant: true explaining it's required to parse modern CSS features (nesting, :has(), etc.) without errors
Ran npm run fix

fregante · 2026-04-30T09:00:22Z

@copilot fix svelte config, then restore your previous fix for that code:

font-weight: 600;
font-size: 12px;
line-height: 1;
etc

…ion, re-add tolerant and font-family-fallbacks Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/97650c59-9480-4ebb-8d37-892e682db23c Co-authored-by: fregante <[email protected]>

Copilot · 2026-04-30T09:06:18Z

@copilot fix svelte config, then restore your previous fix for that code:

...

Done in 4bf3936:

Svelte rules are now disabled for all **/*.css files via Object.fromEntries(Object.keys(sveltePlugin.rules).map(...)) — svelte rules require the Svelte parser and crash on CSS files
Font shorthand restored: font: 600 12px / 1 inherit → font-weight: 600; font-size: 12px; line-height: 1; font-family: inherit
Also added back tolerant: true (needed for @container range syntax in github-bugs.css) and css/font-family-fallbacks: 'off' (needed for font-family: inherit)

fregante · 2026-04-30T08:38:13Z


-			span:is([class*='emptyText'], [class*='developmentHelpText']):not(
-				:has(> button)
-			) {


@g-plane strangely an extra & changed the indentation here, but shouldn't.

Can you provide a minimal reproduction with playground?

https://malva-play.vercel.app/?code=H4sIAAAAAAAAA32OwW7CMBBEz8lX%2BNTEVc0HpKIXJNSeeoAbosgkK2LJ2bW8TgRC%2BffaBtEeqh72MjvzZvow2AYp1Dt%2F6tXneq1aCxpVSziBZx0MoWLTwVH7vRTXsujMtGutZv5aVh%2FMI2xuXzVQN1o4HO7uFWEADNU%2BhX5Sz8tqA23CJoM2CP5uKZ6aXnPNTuPDCoMLly2cI0bmmdmyoAiIC9UJtJfylo4V7Ky%2BNAIJ4TVJc5mxIiEbw%2FVf2BfxUDuYwJIb4up3sO53bS4ocvmbOI4hEMqs%2FVeeby7n8htpCgdhZQEAAA%3D%3D&config=H4sIAAAAAAAAA6vmUlBQKijKzCsJz0wpyVCyUrAw0OHiVMrJzEtNKkpNzPbMCyhOLU3JD0gsSs0rBsqXFJWmctUCANwbK744AAAA&syntax=css

Interestingly this depends on whether the first selector exists. Also linebreakInPseudoParens: true

I saw your commit, thank you!

Co-authored-by: fregante <[email protected]> Co-authored-by: fregante <[email protected]>

Copilot AI and others added 4 commits April 25, 2026 09:31

Add @eslint/css dependency

f0f60a9

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/749e024f-1667-4032-9fc6-7f3f6dc1da83 Co-authored-by: fregante <[email protected]>

WIP: planning CSS lint fixes

23e4fa6

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/749e024f-1667-4032-9fc6-7f3f6dc1da83 Co-authored-by: fregante <[email protected]>

Enable @eslint/css recommended rules and fix all violations

e1292bf

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/749e024f-1667-4032-9fc6-7f3f6dc1da83 Co-authored-by: fregante <[email protected]>

Restore !important on overflow-wrap in readable-title-change-events.css

d9887b9

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/749e024f-1667-4032-9fc6-7f3f6dc1da83 Co-authored-by: fregante <[email protected]>

Copilot AI assigned Copilot and fregante Apr 25, 2026

Copilot created this pull request from a session on behalf of fregante April 25, 2026 09:45 View session

Copilot AI requested a review from fregante April 25, 2026 09:45

Copilot finished work on behalf of fregante April 25, 2026 09:45

fregante reviewed Apr 25, 2026

View reviewed changes

Comment thread source/features/fit-textareas.css Outdated

Comment thread source/features/sticky-comment-header.css Outdated

Comment thread source/features/show-associated-branch-prs-on-fork.css Outdated

fregante closed this Apr 25, 2026

fregante deleted the copilot/enable-eslint-css-rules branch April 25, 2026 09:55

fregante restored the copilot/enable-eslint-css-rules branch April 30, 2026 07:28

fregante reopened this Apr 30, 2026

Copilot started work on behalf of fregante April 30, 2026 07:30 View session

Disable css/use-baseline globally, undo font fix, remove inline css/n…

247f827

…o-invalid-properties exclusions Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/d5e8e282-de39-44b4-9163-14e23bdda5f5 Co-authored-by: fregante <[email protected]>

Copilot finished work on behalf of fregante April 30, 2026 07:34

Copilot AI requested a review from fregante April 30, 2026 07:34

fregante marked this pull request as ready for review April 30, 2026 07:42

fregante changed the title ~~Enable eslint/css recommended rules and fix violations~~ Meta: Add eslint/css Apr 30, 2026

fregante added the meta Related to Refined GitHub itself label Apr 30, 2026

Copilot started work on behalf of fregante April 30, 2026 08:28 View session

Merge main, disable css/no-invalid-properties and css/font-family-fal…

6f1d7e1

…lbacks globally, explain tolerant Co-authored-by: fregante <[email protected]>

fregante changed the title ~~Meta: Add eslint/css~~ Meta: Add eslint/css Apr 30, 2026

Copilot AI changed the title ~~Meta: Add eslint/css~~ Meta: Add eslint/css Apr 30, 2026

Copilot finished work on behalf of fregante April 30, 2026 08:34

fregante added 2 commits April 30, 2026 15:37

Simplify config

fa30885

revert changes to svelte

6c28c07

fregante changed the title ~~Meta: Add eslint/css~~ Meta: Add eslint/css Apr 30, 2026

Copilot started work on behalf of fregante April 30, 2026 09:00 View session

Fix svelte rules crashing on CSS files, restore font shorthand expans…

4bf3936

…ion, re-add tolerant and font-family-fallbacks Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/97650c59-9480-4ebb-8d37-892e682db23c Co-authored-by: fregante <[email protected]>

Copilot finished work on behalf of fregante April 30, 2026 09:07

fregante added 2 commits April 30, 2026 16:23

Update eslint.config.js

289cf26

It was ignored altogether

dc10dbd

fregante enabled auto-merge (squash) April 30, 2026 09:42

Add languageOptions for CSS configuration

ead8b51

fregante merged commit a2b24e9 into main Apr 30, 2026
9 checks passed

fregante reviewed Apr 30, 2026

View reviewed changes

fregante deleted the copilot/enable-eslint-css-rules branch April 30, 2026 09:52

Copilot AI added a commit that referenced this pull request Apr 30, 2026

Meta: Add eslint/css (#9275)

0a8e062

Co-authored-by: fregante <[email protected]> Co-authored-by: fregante <[email protected]>

Uh oh!

Conversation

Copilot AI commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Config changes (eslint.config.js)

CSS fixes

Test URLs

Screenshot

Uh oh!

fregante left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fregante commented Apr 30, 2026

Uh oh!

fregante commented Apr 30, 2026

Uh oh!

Copilot AI commented Apr 30, 2026

Uh oh!

fregante commented Apr 30, 2026

Uh oh!

Copilot AI commented Apr 30, 2026

Uh oh!

fregante commented Apr 30, 2026

Uh oh!

Copilot AI commented Apr 30, 2026

Uh oh!

Uh oh!

fregante Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

g-plane Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

fregante Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

fregante May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 25, 2026 •

edited

Loading

Config changes (`eslint.config.js`)

fregante left a comment •

edited

Loading