Skip to content

clean-repo-filelist-actions - Restore feature#9265

Merged
fregante merged 6 commits into
mainfrom
clean-actions
Apr 30, 2026
Merged

clean-repo-filelist-actions - Restore feature#9265
fregante merged 6 commits into
mainfrom
clean-actions

Conversation

@fregante
Copy link
Copy Markdown
Member

@github-actions github-actions Bot added the bug label Apr 25, 2026
const codeButton = $optional('& > button', container);
container.classList.add('rgh-clean-repo-filelist-actions');

cleanAddFileButton(addFileButton);
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented by GitHub in smaller viewports 👍

return;
}

cleanCodeButton(codeButton);
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can now be done via CSS.

import './clean-repo-filelist-actions.css';

/** Add tooltip on a wrapper to avoid breaking dropdown functionality */
function addTooltipToSummary(childElement: Element, tooltip: string): void {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub hides a label and doesn't add any tooltips. I reckon we can do the same.

However maybe we should also replicate the responsive behavior: only hide "Code" in small windows?

/* Hide agent */
button:has(svg.octicon-agent) {
display: none;
}
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found no button that triggers the exact same UI.

The button in the header with the same icon opens a popup with textarea that seemingly does the same thing, but the UI is different.

I think they're functionally the same so I'm hiding this one.

@fregante fregante marked this pull request as ready for review April 25, 2026 08:31
@fregante
Copy link
Copy Markdown
Member Author

fregante commented Apr 25, 2026

Parts of this were actually implemented by GitHub, see the old UI:

Screenshot 33

versus the new UI. Notice how they also started using the Code icon like we did:

Screenshot 34

@SunsetTechuila
Copy link
Copy Markdown
Member

SunsetTechuila commented Apr 26, 2026

image

Comment thread source/features/clean-repo-filelist-actions.css
Comment thread source/features/clean-repo-filelist-actions.css Outdated
Comment thread source/features/clean-repo-filelist-actions.css Outdated
@fregante
Copy link
Copy Markdown
Member Author

Thanks for fixing it!

@fregante fregante merged commit dd582e5 into main Apr 30, 2026
10 checks passed
@fregante
Copy link
Copy Markdown
Member Author

You should pick one 😃

Screenshot

@fregante fregante deleted the clean-actions branch April 30, 2026 08:31
@SunsetTechuila
Copy link
Copy Markdown
Member

It's GitHub that should stop using my non-public email for suggestions

@fregante
Copy link
Copy Markdown
Member Author

fregante commented Apr 30, 2026

There's a setting for that (I thought)

Copilot AI pushed a commit that referenced this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

clean-repo-filelist-actions is broken

2 participants