Skip to content

jump-to-conversation-close-event - Restore on PRs#9264

Merged
fregante merged 1 commit into
mainfrom
close-event
Apr 25, 2026
Merged

jump-to-conversation-close-event - Restore on PRs#9264
fregante merged 1 commit into
mainfrom
close-event

Conversation

@fregante
Copy link
Copy Markdown
Member

Test URLs

#9231

Screenshot

GitHub has a couple of bugs around scrolling to the event but that's not this feature's responsibility to fix

gif233

@fregante fregante added the bug label Apr 25, 2026

export const statusBadgeSelector = [
'span[class*="StateLabel"]',
// TOdO: Drop both in September 2026
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TOdO: Drop both in September 2026
// TOdO: dRoP bOtH iN sEpTeMbEr 2026

Copy link
Copy Markdown
Member

@SunsetTechuila SunsetTechuila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a similar commit, but I don't really remember why I haven't opened a PR. If there were any gotchas, I can't find them now

@fregante fregante merged commit 7e1e527 into main Apr 25, 2026
12 checks passed
@fregante fregante deleted the close-event branch April 25, 2026 07:46
@SunsetTechuila
Copy link
Copy Markdown
Member

Judging by the dates, I decided to fix the locked-issue first, but that took two weeks and I forgot to return to jump-to-conversation-close-event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

jump-to-conversation-close-event broken on new PR view

2 participants