Skip to content

quick-review - Speed up "Files changed" page opening#9259

Merged
SunsetTechuila merged 15 commits into
mainfrom
quick-review-speed
Apr 26, 2026
Merged

quick-review - Speed up "Files changed" page opening#9259
SunsetTechuila merged 15 commits into
mainfrom
quick-review-speed

Conversation

@SunsetTechuila
Copy link
Copy Markdown
Member

@SunsetTechuila SunsetTechuila commented Apr 24, 2026

Depends on #9258

The problem with the current implementation is that it forces a hard navigation instead of client-side soft navigation (#9192 (comment)), significantly slowing down page loading.

Test URLs

this PR

Screenshot

Before:

chrome_UqGcVX9cQw

After:

chrome_2AWVbKhBoY

@SunsetTechuila SunsetTechuila changed the title quick-review - Speed up page opening quick-review - Speed up "Files changed" page opening Apr 24, 2026
Comment thread source/features/quick-review.tsx Outdated
@fregante
Copy link
Copy Markdown
Member

Let's discuss what we should do.

Archive Refined GitHub 😂

@SunsetTechuila
Copy link
Copy Markdown
Member Author

Let's discuss what we should do.

Archive Refined GitHub 😂

I decided to use AbortSignal.timeout instead

Comment thread source/features/quick-review.tsx Outdated
@SunsetTechuila
Copy link
Copy Markdown
Member Author

Check the comparison

@fregante
Copy link
Copy Markdown
Member

Check the comparison

🏎️💨💨💨💨

@SunsetTechuila SunsetTechuila marked this pull request as ready for review April 24, 2026 15:54
data-hotkey="v"
aria-label="Hotkey: V"
onClick={event => {
event.preventDefault(); // Fix our buttons being removed
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

Copy link
Copy Markdown
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged if the old UI was tested with the latest commit

@SunsetTechuila SunsetTechuila merged commit 1a589da into main Apr 26, 2026
10 checks passed
@SunsetTechuila SunsetTechuila deleted the quick-review-speed branch April 26, 2026 08:27
Copilot AI pushed a commit that referenced this pull request Apr 30, 2026
review now
</a>
{isNewFilesChangedExperienceEnabled()
? <button
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- <a href>
+ <button>

Can no longer open in a new tab 🥲

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will address that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants