Skip to content

conversation-authors - Disable collaborator highlighting on PRs#9194

Merged
fregante merged 3 commits into
mainfrom
copilot/disable-conversation-authors-on-pr-lists
Apr 14, 2026
Merged

conversation-authors - Disable collaborator highlighting on PRs#9194
fregante merged 3 commits into
mainfrom
copilot/disable-conversation-authors-on-pr-lists

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 12, 2026

highlightCollaborators was running on both repo issue lists and PR lists via isRepoIssueOrPRList. This narrows it to isRepoIssueList only.

- pageDetect.isRepoIssueOrPRList,
+ pageDetect.isRepoIssueList,

Test URLs

Screenshot

Copilot AI changed the title [WIP] Disable conversation-authors on PR lists conversation-authors: restrict collaborator highlighting to issue lists only Apr 12, 2026
Copilot AI requested a review from fregante April 12, 2026 16:23
@github-actions github-actions Bot changed the title conversation-authors: restrict collaborator highlighting to issue lists only conversation-authors: restrict collaborator highlighting to issue lists only Apr 12, 2026
@fregante fregante marked this pull request as ready for review April 12, 2026 16:31
Comment thread source/features/conversation-authors.tsx Outdated
Comment thread source/features/conversation-authors.tsx Outdated
@SunsetTechuila

This comment was marked as off-topic.

@SunsetTechuila

This comment was marked as off-topic.

@SunsetTechuila SunsetTechuila force-pushed the copilot/disable-conversation-authors-on-pr-lists branch from 8fff4ca to d3d66a7 Compare April 13, 2026 16:59
@SunsetTechuila SunsetTechuila changed the title conversation-authors: restrict collaborator highlighting to issue lists only conversation-authors - Disable collaborator highlighting on PRs Apr 13, 2026
@fregante
Copy link
Copy Markdown
Member

Please avoid force-pushing to this PR. It makes it harder for reviewers to track what changed since the last review.

Just push new commits on top of the branch instead — PRs are squashed on merge, so the commit history doesn't need to be clean.

@SunsetTechuila
Copy link
Copy Markdown
Member

I force-pushed my own commits none of which you've seen

@fregante
Copy link
Copy Markdown
Member

The suggestion still applies, the commit history doesn't need to be clean. In order for me to know what happened I still have to check the force-push comparison

@fregante fregante merged commit 0500c2c into main Apr 14, 2026
12 checks passed
@github-actions
Copy link
Copy Markdown

To maintainers: Please add labels to this PR

@SunsetTechuila SunsetTechuila deleted the copilot/disable-conversation-authors-on-pr-lists branch April 14, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants