quick-review - Enhance native "Add your review" button#9192
Merged
Conversation
SunsetTechuila
changed the title
quick-review - Enhance native "Add review" buttonquick-review - Enhance native "Add your review" button
fregante
reviewed
Apr 12, 2026
fregante
approved these changes
Apr 12, 2026
| } | ||
|
|
||
| function enhanceNativeReviewButton(button: HTMLAnchorElement): void { | ||
| // Clone button to remove GitHub's event listeners, which interfere with ours |
SunsetTechuila
commented
Apr 15, 2026
| } | ||
|
|
||
| function enhanceNativeReviewButton(button: HTMLAnchorElement): void { | ||
| // Clone button to remove GitHub's event listeners, which interfere with ours |
Member
Author
There was a problem hiding this comment.
Namely this one from React Router:
It doesn't use the current link href that we modify. Instead, it uses the to prop that was passed when the component was created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test URLs
This PR
Screenshot