Skip to content

Meta: Fix @typescript-eslint/naming-convention errors#9135

Merged
SunsetTechuila merged 9 commits into
refined-github:mainfrom
SunsetTechuila:lint
Mar 29, 2026
Merged

Meta: Fix @typescript-eslint/naming-convention errors#9135
SunsetTechuila merged 9 commits into
refined-github:mainfrom
SunsetTechuila:lint

Conversation

@SunsetTechuila
Copy link
Copy Markdown
Member

@SunsetTechuila SunsetTechuila commented Mar 28, 2026 •
edited
Loading

Makes struggling less constant: #9133 (comment)

Makes DX inside the IDE less insufferable

Test URLs

Screenshot

@SunsetTechuila SunsetTechuila added the meta Related to Refined GitHub itself label Mar 28, 2026
@SunsetTechuila SunsetTechuila marked this pull request as ready for review March 28, 2026 03:43
@SunsetTechuila
Copy link
Copy Markdown
Member Author

SunsetTechuila commented Mar 28, 2026 •
edited
Loading

We can also disable only snake and kebab cases: #9133 (comment)

fregante
fregante previously approved these changes Mar 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessss, thank you! Those changes were sort of grandfathered in for a few reasons, but were not meant to stay that way.

@fregante fregante marked this pull request as draft March 28, 2026 06:52
fregante
fregante reviewed Mar 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to check first

Comment thread source/background.ts
Comment thread source/feature-manager.tsx
Comment thread source/features/list-prs-for-branch.tsx
Comment thread source/features/show-associated-branch-prs-on-fork.tsx
Comment thread source/features/update-pr-from-base-branch.tsx
Comment thread source/github-helpers/api.tsx
Comment thread source/github-helpers/github-token.ts Outdated
Comment thread source/options-storage.ts
@fregante fregante dismissed their stale review March 28, 2026 07:03

Needs changed

@SunsetTechuila SunsetTechuila requested a review from fregante March 28, 2026 07:36
@SunsetTechuila
Copy link
Copy Markdown
Member Author

SunsetTechuila commented Mar 28, 2026 •
edited
Loading

Changing PR to Pr, GH to Gh, GraphQL to GraphQl and UI to Ui is diabolical

@SunsetTechuila
Copy link
Copy Markdown
Member Author

SunsetTechuila commented Mar 28, 2026

Everything has been rechecked and all review comments have been addressed

image

@SunsetTechuila SunsetTechuila marked this pull request as ready for review March 28, 2026 08:00
SunsetTechuila
SunsetTechuila commented Mar 28, 2026
View reviewed changes
Comment thread source/options-storage.ts Outdated
@fregante

This comment was marked as off-topic.

Sign in to view
@fregante

This comment was marked as off-topic.

Sign in to view
@SunsetTechuila

This comment was marked as off-topic.

Sign in to view
@fregante

This comment was marked as off-topic.

Sign in to view
@SunsetTechuila

This comment was marked as resolved.

Sign in to view
@fregante

This comment was marked as resolved.

Sign in to view
@SunsetTechuila

This comment was marked as resolved.

Sign in to view
@SunsetTechuila

This comment was marked as resolved.

Sign in to view
@SunsetTechuila SunsetTechuila merged commit 9ad9bc4 into refined-github:main Mar 29, 2026
9 checks passed
@SunsetTechuila SunsetTechuila deleted the lint branch March 29, 2026 17:36
@fregante
Copy link
Copy Markdown
Member

fregante commented Mar 29, 2026

So I got the location right 😅 and if the test is still isBackgroundPage it needs an update to isBackground for MV3. I'm surprised this hasn't caused issues sooner https://github.com/fregante/webext-options-sync-per-domain/blob/main/index.ts

@SunsetTechuila
Copy link
Copy Markdown
Member Author

SunsetTechuila commented Mar 29, 2026

it needs an update to isBackground for MV3

No, it's my fault - I've removed the check

@SunsetTechuila
Copy link
Copy Markdown
Member Author

SunsetTechuila commented Mar 29, 2026

Should I add this commit to .git-blame-ignore-revs?

@fregante
Copy link
Copy Markdown
Member

fregante commented Mar 30, 2026

it needs an update to isBackground for MV3

No, it's my fault - I've removed the check

I understand that part, but it should be isBackground, not isBackgroundPage in webext-options-sync-per-domain. I'll have to update it

SunsetTechuila added a commit that referenced this pull request Mar 30, 2026
@SunsetTechuila
Meta: Exclude #9135 from git blame
2646905
fregante pushed a commit to SunsetTechuila/refined-github that referenced this pull request Apr 16, 2026
@SunsetTechuila @fregante
Meta: Exclude refined-github#9135 from git blame
dfe0393
@SunsetTechuila SunsetTechuila mentioned this pull request Apr 19, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fregante fregante fregante approved these changes

Assignees

No one assigned

Labels

meta Related to Refined GitHub itself

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SunsetTechuila @fregante