restore-file - Fix discarding new or empty files#9133
Merged
Conversation
SunsetTechuila
force-pushed
the
restore-file-empty-and-new
branch
from
38a44e6 to
37411b8
Compare
Member
|
What was the decision on new files? I remember we just did not show the button at some point because it's a duplicate of the Delete File menu item |
Member
Author
Member
Author
|
Still relevant |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
fregante
reviewed
Mar 28, 2026
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
What's the status of this PR and the feature itself? Does it not work fully in every case we want to cover? What are the limitations if any? Is the PR title up to date? |
fregante
approved these changes
Apr 2, 2026
Member
Author
Ready to be merged
It works for everything other than binary, new, or empty files
We can also get 404 if we pass wrong name/ref to the query
Yes |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9120 (comment)
I believe it's #7650 that broke new files support
Test URLs
https://github.com/refined-github/sandbox/pull/128/changes
Screenshot