table-input - Show tooltip for entire button#9084
Merged
Merged
Conversation
github-actions
Bot
changed the title
table-input - Show tooltip for entire button
fregante
approved these changes
Mar 12, 2026
| 'action-menu': IntrinsicElements.HTMLELement; | ||
| 'focus-group': IntrinsicElements.HTMLELement; | ||
| 'action-list': IntrinsicElements.HTMLELement; | ||
| 'tool-tip': IntrinsicElements.HTMLElement; |
Member
There was a problem hiding this comment.
I'm surprised we never used this before. Is this their latest implementation of tooltipped? I was under the impression we already used the successor of .tooltipped
Member
Author
There was a problem hiding this comment.
It's been some time since I first saw this (over a year I think). In some places (like buttons in site header) GitHub uses plain https://primer.style/product/components/tooltip/ instead of <tool-tip>, but I believe they use the same implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Super nit-picking cosmetic change incoming. The tooltip currently only applies to the icon, which is a bit off.
Can't just move
.tooltippedto<summary>as that would show the tooltip together with the table popup.Test URLs
Here
Screenshot
Screen.Recording.2026-03-12.at.5.05.19.PM.mov
Screen.Recording.2026-03-12.at.5.06.11.PM.mov