@jfagoagas #9049 (comment)

@jfagoagas #9049 (comment)

Thanks for the heads up, addressed in 02baf2f

What we've been trying to say:

• do not use event.submitter, drop that selector check altogether
• use a better selector than just form

It's not that easy - GitHub captures the submission event before us. I'll take it from there

GitHub captures the submission event before us

If GitHub actually triggers and awaits a real submit event, we should be able to capture it by attaching the listener on the form element rather than using event delegation. Can you try that? The current code is a bit fickle.

The code would look something like observe(form selector, form => form.addEventListener('submit', fn, true))

Also I just remembered we have avoid-accidental-submissions that does the same thing, except differently. Do you feel this should be rolled into that feature and use the same logic instead of confirm()?

I'm also ok with merging this as is and keep my changes as a wishlist.

The code would look something like observe(form selector, form => form.addEventListener('submit', fn, true))

This doesn't work - they added a window-level listener with capture: true

Also I just remembered we have avoid-accidental-submissions that does the same thing, except differently. Do you feel this should be rolled into that feature and use the same logic instead of confirm()?

avoid-accidental-submissions only prevents submission on the first Enter press, nothing more. If you agree that we should show a confirmation dialog before publishing a new release, then - as part of avoid-accidental-submissions - it would be a special case. Personally, I would leave everything as it is

only prevents submission on the first Enter press, nothing more

Yes, we thought you get one chance at fat-fingering while filling that form. I guess the release page is longer and has more chances though.

Good to go

So it should work.

It doesn't 🤷‍♂️. Maybe it's because requestSubmit, which is called by quickSubmit, re-dispatches the event as a custom one. There is a lot going on, I don't know

@jfagoagas Thank you

@jfagoagas Thank you

Thank you both! Great review 🙌

I got asked 3 times and I hate it already. See #9169