Skip to content

clean-repo-tabs - Fix wiki tab counter#9002

Merged
fregante merged 3 commits into
refined-github:mainfrom
dnicolson:fix-wiki-counter
Mar 11, 2026
Merged

clean-repo-tabs - Fix wiki tab counter#9002
fregante merged 3 commits into
refined-github:mainfrom
dnicolson:fix-wiki-counter

Conversation

@dnicolson
Copy link
Copy Markdown
Contributor

@dnicolson dnicolson commented Feb 21, 2026

This fixes:

Refined GitHub: clean-repo-tabs
errors.js:78 📕 26.2.19 → ElementNotFoundError: Expected element not found: .Counter
    at expectElement (select-dom.js:21:11)
    at setTabCounter (clean-repo-tabs.js:29:21)
    at updateWikiTab (clean-repo-tabs.js:82:3)
    at async feature-manager.js:197:20
    at async Promise.all (index 1)
    at async asyncForEach (async-for-each.js:6:2)

Test URLs

https://github.com/Netflix/Hystrix/wiki

Screenshot

Before After
PixelSnap 2026-02-21 at 20 45 43@2x PixelSnap 2026-02-21 at 20 45 50@2x

fregante
fregante reviewed Mar 10, 2026
View reviewed changes
Comment thread source/features/clean-repo-tabs.tsx Outdated
const tabCounter = $('.Counter', tab);
let tabCounter = $optional('.Counter, .num', tab);
if (!tabCounter) {
const wrapper = document.createElement('span');
Copy link
Copy Markdown
Member

@fregante fregante Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use JSX to create these elements instead?

Copy link
Copy Markdown
Contributor Author

@dnicolson dnicolson Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it's just a little more code.

@fregante fregante changed the title clean-repo-tabs: Fix wiki tab counter clean-repo-tabs - Fix wiki tab counter Mar 10, 2026
@fregante fregante added the bug label Mar 10, 2026
fregante
fregante approved these changes Mar 10, 2026
View reviewed changes
Comment thread source/features/clean-repo-tabs.tsx Outdated
@fregante fregante merged commit 012f6aa into refined-github:main Mar 11, 2026
8 checks passed
@fregante
Copy link
Copy Markdown
Member

fregante commented Mar 11, 2026

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fregante fregante fregante approved these changes

Assignees

No one assigned

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dnicolson @fregante