Skip to content

suggest-commit-title-limit - Restore feature#8933

Merged
fregante merged 21 commits into
mainfrom
suggest-commit-title-limit
Mar 3, 2026
Merged

suggest-commit-title-limit - Restore feature#8933
fregante merged 21 commits into
mainfrom
suggest-commit-title-limit

Conversation

@SunsetTechuila
Copy link
Copy Markdown
Member

@SunsetTechuila SunsetTechuila commented Feb 3, 2026

#8123

#8946

Test URLs

refined-github/sandbox#8

https://github.com/refined-github/refined-github/compare/main...karlhorky:refined-github:test/bun?expand=true

https://github.com/refined-github/refined-github/edit/main/.nvmrc

Screenshot

image image image image

@SunsetTechuila SunsetTechuila changed the title Suggest commit title limit suggest-commit-title-limit - Restore feature Feb 3, 2026
Comment thread source/features/suggest-commit-title-limit.css Outdated
@SunsetTechuila SunsetTechuila marked this pull request as ready for review February 4, 2026 02:36
Comment thread source/features/suggest-commit-title-limit.css Outdated
@SunsetTechuila

This comment was marked as outdated.

@SunsetTechuila SunsetTechuila marked this pull request as draft February 11, 2026 15:39
@SunsetTechuila SunsetTechuila marked this pull request as ready for review February 21, 2026 13:43
@SunsetTechuila
Copy link
Copy Markdown
Member Author

@fregante ready to be reviewed

@SunsetTechuila SunsetTechuila requested a review from fregante March 3, 2026 00:58
@SunsetTechuila
Copy link
Copy Markdown
Member Author

the last change 🙏

@fregante
Copy link
Copy Markdown
Member

fregante commented Mar 3, 2026

Please don't ask me to review the same PR 4 times

@fregante fregante merged commit 756a0e2 into main Mar 3, 2026
8 checks passed
@fregante fregante deleted the suggest-commit-title-limit branch March 3, 2026 02:31
@SunsetTechuila
Copy link
Copy Markdown
Member Author

But I asked only twice

@fregante
Copy link
Copy Markdown
Member

fregante commented Mar 3, 2026

If the PR is "ready for review" that's already asking for it to be reviewed. You pushed commits after my review, should I let the PR simmer for a few more weeks instead? Because that's what I've been doing when these "mismatched expectations" happen.

@mschoettle
Copy link
Copy Markdown
Contributor

The change to the CSS rule caused a regression. Attempt to fix it: #9035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants