Skip to content

batch-mark-files-as-viewed - Restore on new Files changed experience#8930

Merged
SunsetTechuila merged 11 commits into
mainfrom
batch-mark-files-as-viewed
Feb 25, 2026
Merged

batch-mark-files-as-viewed - Restore on new Files changed experience#8930
SunsetTechuila merged 11 commits into
mainfrom
batch-mark-files-as-viewed

Conversation

@SunsetTechuila
Copy link
Copy Markdown
Member

@SunsetTechuila SunsetTechuila commented Feb 2, 2026

#8504

Test URLs

https://github.com/refined-github/sandbox/pull/55/changes?new_files_changed=false

https://github.com/refined-github/sandbox/pull/55/changes?new_files_changed=true

Screenshot

: elementExists('.octicon-checkbox-fill', viewedToggle);
}

// A single click is somehow causing two separate trusted `click` events, so it needs to be debounced
Copy link
Copy Markdown
Member Author

@SunsetTechuila SunsetTechuila Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single click is somehow causing two separate trusted click events

Doesn't happen when the checkbox is targeted instead of the label containing it

@SunsetTechuila

This comment was marked as off-topic.

@fregante

This comment was marked as off-topic.

@SunsetTechuila
Copy link
Copy Markdown
Member Author

SunsetTechuila commented Feb 3, 2026

I tested this against the latest RGH release and I don't think I changed the behavior

@SunsetTechuila SunsetTechuila marked this pull request as ready for review February 3, 2026 19:20
@SunsetTechuila

This comment was marked as off-topic.

Copy link
Copy Markdown
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still have access to the old view? Preserving compatibility with both might be tricky here

Comment thread source/features/batch-mark-files-as-viewed.tsx Outdated
Comment thread source/features/batch-mark-files-as-viewed.tsx Outdated
@SunsetTechuila
Copy link
Copy Markdown
Member Author

SunsetTechuila commented Feb 13, 2026

Do you still have access to the old view?

Ofc, I linked both views. Are you asking because you don't have access?

image

I tested this against the latest RGH release and I don't think I changed the behavior

Also, how would I compare the behavior without access to the old view

@fregante
Copy link
Copy Markdown
Member

I'm computerless for at least the next week, I've been reviewing from the GitHub app 😅

@mwarkentin
Copy link
Copy Markdown

Hoping this can land soon, I installed the extension in hopes of preventing carpal tunnel.. I've got a bunch of PRs that have hundreds of files changed like this.. 😓

image

Copy link
Copy Markdown
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this continues to work on both new and old views

@SunsetTechuila SunsetTechuila merged commit 53e14d3 into main Feb 25, 2026
8 checks passed
@SunsetTechuila SunsetTechuila deleted the batch-mark-files-as-viewed branch February 25, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants