Skip to content

Add keyboard shortcuts for conversation-activity-filter#5423

Merged
fregante merged 7 commits into
refined-github:mainfrom
14113:conversation-activity-filter-shortcuts
Feb 21, 2022
Merged

Add keyboard shortcuts for conversation-activity-filter#5423
fregante merged 7 commits into
refined-github:mainfrom
14113:conversation-activity-filter-shortcuts

Conversation

@14113
Copy link
Copy Markdown
Contributor

@14113 14113 commented Feb 18, 2022

Closes #5379

Add new shortcuts into the conversation-activity-filter feature:

  • One h press: hide events
  • Two h presses: hide everything
  • Three h presses: show everything
  • Repeat

Test URLs

#4029

Screenshot

109589540-15a73d00-7ad0-11eb-9d4c-d31e403435f0

Keyboard shortcuts
Screenshot 2022-02-18 at 20 03 07

Comment thread source/features/conversation-activity-filter.tsx Outdated
Copy link
Copy Markdown
Contributor

@cheap-glitch cheap-glitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Comment thread source/features/conversation-activity-filter.tsx Outdated
Comment thread source/features/conversation-activity-filter.tsx
Comment thread source/features/conversation-activity-filter.tsx Outdated
@cheap-glitch cheap-glitch changed the title Add into conversation-activity-filter shortcuts Add keyboard shortcuts for conversation-activity-filter Feb 18, 2022
@fregante
Copy link
Copy Markdown
Member

Thanks for the PR! I was thinking about having a single, cycling shortcut.

One press: hide events
Two presses: hide everything
Three presses: show everything
Repeat

Copy link
Copy Markdown
Contributor

@cheap-glitch cheap-glitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Firefox. Very neat!

Copy link
Copy Markdown
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go

Comment thread source/features/conversation-activity-filter.tsx Outdated
@fregante fregante merged commit 328a1c9 into refined-github:main Feb 21, 2022
@fregante
Copy link
Copy Markdown
Member

Děkuji za PR, Adam!

@14113 14113 deleted the conversation-activity-filter-shortcuts branch February 21, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Add shortcuts into conversation-activity-filter options

3 participants