Enable edit-comments-faster on Discussions#4336
Conversation
darkred
changed the title
parse-backticks work in Discussionsedit-comments-faster work in Discussions
darkred
changed the title
edit-comments-faster work in Discussionsedit-comments-faster on Discussions
Thanks to yakov116
| comment | ||
| .closest('.js-comment')! | ||
| .querySelector('.timeline-comment-actions > details:last-child')! // The dropdown | ||
| .querySelector('.timeline-comment-actions > details:last-child, .timeline-comment-actions details:last-child')! // The dropdown |
There was a problem hiding this comment.
Did you check that this does not make issues in other places. There is probably a reason that we used such a specific selector.
There was a problem hiding this comment.
I only tested in issues, Discussions (all non-locked) and this PR page.
I don't have any locked conversation URL to have participated in.
As I wrote in the OP, I can only suggest a more specific alternative additional selector:
.timeline-comment-actions > div > details:last-child
There was a problem hiding this comment.
Either way the 2 selectors currently overlap. The first one is unnecessary because the second one already covers that.
@yakov116’s notes still apply
There was a problem hiding this comment.
Ok, I kept only the second one. Thank you.
There was a problem hiding this comment.
Did you check if locked issues work?
There was a problem hiding this comment.
Yes, I tried it in a test repo I have made:
I locked an issue, discussion and PR page, and it works ok in all
(with the selector I kept .timeline-comment-actions details:last-child ).
Co-authored-by: yakov116 <[email protected]>
Co-authored-by: yakov116 <[email protected]>
3 participants
Closes #4334
Test URLs
tophf/mpiv#50
Screenshot
Note to reviewers
.timeline-comment-actions details:last-child(or.timeline-comment-actions > div > details:last-child) is for discussions