Skip to content

Meta: Lint code and improve readme#4076

Merged
fregante merged 16 commits into
refined-github:mainfrom
cheap-glitch:lint-readme
Mar 16, 2021
Merged

Meta: Lint code and improve readme#4076
fregante merged 16 commits into
refined-github:mainfrom
cheap-glitch:lint-readme

Conversation

@cheap-glitch
Copy link
Copy Markdown
Contributor

@cheap-glitch cheap-glitch commented Mar 8, 2021

Closes #4057

Opening this as a draft in case we notice some more fixes.

Comment thread readme.md
@yakov116 yakov116 added the meta Related to Refined GitHub itself label Mar 8, 2021
@cheap-glitch
Copy link
Copy Markdown
Contributor Author

Maybe this PR could also take care of #4057 + add guidelines for screenshots as mentioned in #4045 (comment)?

@yakov116
Copy link
Copy Markdown
Member

yakov116 commented Mar 9, 2021

Maybe this PR could also take care of #4057

Yes I am almost done

add guidelines for screenshots as mentioned in #4045 (comment)?

👍

@fregante
Copy link
Copy Markdown
Member

Can you include this here too? It's just an indentation fix

https://github.com/sindresorhus/refined-github/blob/10d08987fae5fe87cca1a58a1b94807fd4a4d181/source/features/comment-fields-keyboard-shortcuts.tsx#L15-L18

@cheap-glitch cheap-glitch changed the title Meta: Lint readme Meta: Lint and improve readme Mar 13, 2021
@cheap-glitch cheap-glitch marked this pull request as ready for review March 13, 2021 17:11
Comment thread readme.md Outdated
Comment thread readme.md Outdated
Comment thread readme.md Outdated
Comment thread readme.md Outdated
@fregante
Copy link
Copy Markdown
Member

@yakov116 we already have title:"dropped feature", no need for another label

@fregante
Copy link
Copy Markdown
Member

What feature do you think could replace open-all-conversations in the highlights table? I don't think it's that 🔥 anymore

Co-authored-by: Federico <[email protected]>
@cheap-glitch
Copy link
Copy Markdown
Contributor Author

What feature do you think could replace open-all-conversations in the highlights table?

  • Even though I don't use it often, I find first-published-tag-for-merged-pr really neat
  • Same for follow-file-renames
  • hide-markdown-diff seems relatively popular, given the reactions on the original PR

@yakov116
Copy link
Copy Markdown
Member

yakov116 commented Mar 14, 2021

@yakov116 we already have title:"dropped feature", no need for another label

Sorry I misread

I would do two links. "Implemented by GitHub" and "Dropped features".

Originally posted by #4057 (comment)

EDIT: Fixed

@fregante
Copy link
Copy Markdown
Member

fregante commented Mar 14, 2021

Agreed. I rarely see it though because it's so small and doesn't appear in the sticky header.

Indeed. There's even 1 or 2 other extensions for this, but they don't work as well. Maybe we should pick this

You can put a 🔥 next to it then. If you'd like some twitter followers, you can post a tweet about it and I'll retweet it

@yakov116
Copy link
Copy Markdown
Member

yakov116 commented Mar 14, 2021

Agreed. I rarely see it though because it's so small and doesn't appear in the sticky header.

image

In my RG it does 😠

Copy link
Copy Markdown
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can be merged

@yakov116
Copy link
Copy Markdown
Member

@cheap-glitch can you change

https://github.com/sindresorhus/refined-github/blob/86f9ea1fa35a0658202da831dd07c497bbbff605/source/features/sync-pr-commit-title.tsx#L19-L21

to use getConversationNumber() please

Thanks

Comment thread source/features/sync-pr-commit-title.tsx Outdated
Comment thread source/features/sync-pr-commit-title.tsx Outdated
@cheap-glitch cheap-glitch changed the title Meta: Lint and improve readme Meta: Lint code and improve readme Mar 15, 2021
Comment thread source/options-storage.ts

// TODO[2021-10-01]: Drop classes `muted-link`, `link-gray`, `link-gray-dark`, `text-gray`, `text-gray-light` and `text-gray-dark` #4021
const migrations = [
featureWasRenamed('pr-easy-toggle-files', 'easy-toggle-files'), // Merged in December
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should start leaving migrations a few more months, they don't really harm anyone. They're useful to who doesn't update super often (due to GHE or whatever reason)

@fregante fregante merged commit 0e44fb9 into refined-github:main Mar 16, 2021
@cheap-glitch cheap-glitch deleted the lint-readme branch March 16, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Related to Refined GitHub itself

Development

Successfully merging this pull request may close these issues.

Replace Previously part of Refined GitHub section in readme with a PR list link

3 participants