Skip to content

Enable edit-comments-faster on locked conversations#4042

Merged
fregante merged 2 commits into
mainfrom
fix-edit-locked
Mar 1, 2021
Merged

Enable edit-comments-faster on locked conversations#4042
fregante merged 2 commits into
mainfrom
fix-edit-locked

Conversation

@fregante
Copy link
Copy Markdown
Member

@fregante fregante commented Mar 1, 2021

Fixes #4031

Testable on #4030

Screenshot

Notice the edit button on a locked issue:

Screen Shot 13

@fregante fregante added the bug label Mar 1, 2021
comment.closest('.js-comment')!.querySelector('.js-comment-header-reaction-button')!.after(
comment
.closest('.js-comment')!
.querySelector('.timeline-comment-actions > details:last-child')! // The dropdown
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less specific selector, unfortunately, but the dropdown doesn't have any specific class.

@fregante fregante merged commit 37989d0 into main Mar 1, 2021
@fregante fregante deleted the fix-edit-locked branch March 1, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

edit-comments-faster is failing on locked issues

1 participant