Add conversation-activity-filter feature#4029
Merged
Merged
Conversation
might fix lint problems
Member
Author
conversation-timeline-filter featureconversation-activity-filter feature
Member
|
🔥 Looking better by the moment! |
1 task
|
This is great! Thanks @fregante! ^.^ |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #3764
Closes #615
Replaces #3847
Screenshot
(readme screenshot wip)
Test
Every event is on #4030
Some events are on #3847 but you can also test the native "X event hidden" there, which defers loading events in the middle
To test this feature, it's best to replace the CSS with:
So that the elements are highlighted instead of hidden (which is harder to keep track of, mentally)
Example of the above CSS in "Show only unresolved comments" state:
Wishlist (new PR?)
Add "Events hidden, click to undo" message at the end of the conversationSince it's always visible in the header now, this is no longer neededIssueHunt Summary
Referenced issues
This pull request has been submitted to: