Skip to content

Add conversation-activity-filter feature#4029

Merged
fregante merged 117 commits into
mainfrom
conversation-event-filter
Mar 5, 2021
Merged

Add conversation-activity-filter feature#4029
fregante merged 117 commits into
mainfrom
conversation-event-filter

Conversation

@fregante
Copy link
Copy Markdown
Member

@fregante fregante commented Feb 27, 2021

Closes #3764
Closes #615
Replaces #3847

Screenshot

(readme screenshot wip)

Screen Shot 1

Screen Shot 4

Screen Shot 3

Test

Every event is on #4030
Some events are on #3847 but you can also test the native "X event hidden" there, which defers loading events in the middle

To test this feature, it's best to replace the CSS with:

:root:root .rgh-conversation-timeline-filtered {
	/* display: none !important; */
	outline: solid 5px red;
}

So that the elements are highlighted instead of hidden (which is harder to keep track of, mentally)

Example of the above CSS in "Show only unresolved comments" state:

Screen Shot 7

Wishlist (new PR?)

  • Move to header so it's always visible
  • Ensure that the 2 instances are synced
  • Hide resolved review comments that are among unresolved comments: Test-only PR with every event #4030 (comment)
  • [/] Add "Events hidden, click to undo" message at the end of the conversation Since it's always visible in the header now, this is no longer needed

IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@fregante fregante marked this pull request as ready for review March 2, 2021 03:11
@fregante
Copy link
Copy Markdown
Member Author

fregante commented Mar 2, 2021

Moved to the header. This is much cleaner and visible, and also doesn't lengthen the sidebar, which would make sticky-sidebar activate less often.

This is a 🔥 feature 😁

And it’s done. Now it only needs reviews.

Screen Shot 5

@fregante fregante changed the title Add conversation-timeline-filter feature Add conversation-activity-filter feature Mar 2, 2021
@yakov116
Copy link
Copy Markdown
Member

yakov116 commented Mar 2, 2021

🔥 Looking better by the moment!

@fregante fregante mentioned this pull request Mar 2, 2021
1 task
@fregante fregante merged commit 4307bfc into main Mar 5, 2021
@fregante fregante deleted the conversation-event-filter branch March 5, 2021 05:08
@pradyunsg
Copy link
Copy Markdown

This is great! Thanks @fregante! ^.^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Toggle/Hide TimelineItem elements (e.g. added label etc) Collapse large sequences of label, milestone, etc changes

4 participants