Repository navigation
Tests: fail fast in GetCleanDatabase when a cluster node is disconnected - #585
Merged
Merged
Conversation
Skipping a disconnected node in the per-test FLUSHALL loop left its keys and indices in place, so one connectivity blip in CI cascaded into ~300 'index already exists' failures in later tests. Wait briefly for reconnect, then throw naming the unreachable endpoints.
mgravell
marked this pull request as ready for review
October 19, 2026 08:17
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipping a disconnected node in the per-test FLUSHALL loop left its keys and indices in place, so one connectivity blip in CI cascaded into ~300 'index already exists' failures in later tests. Wait briefly for reconnect, then throw naming the unreachable endpoints.
Note
Low Risk
Test-harness-only change; production client code is unaffected, though cluster tests may fail earlier when connectivity is flaky instead of producing misleading downstream failures.
Overview
Cluster test setup in
GetCleanDatabaseno longer silently skips disconnected primaries duringFLUSHALL. It now resolves all cluster servers up front, waits up to ~2s for reconnects, and throws with the unreachable endpoints if any node is still down—so CI does not run tests against a partially flushed cluster.Replica skipping is unchanged; standalone behavior is unchanged.
Reviewed by Cursor Bugbot for commit 0203813. Bugbot is set up for automated code reviews on this repo. Configure here.