Skip to content

updated naming convention - #1026

Merged
openshift-merge-bot[bot] merged 5 commits into
redhat-developer:masterfrom
akhilnittala:usr/akhil/GITOPS_7992
Dec 9, 2025
Merged

updated naming convention#1026
openshift-merge-bot[bot] merged 5 commits into
redhat-developer:masterfrom
akhilnittala:usr/akhil/GITOPS_7992

Conversation

@akhilnittala

Copy link
Copy Markdown
Member

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
just change in naming convention
Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
GITOPS-7992
Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci

openshift-ci Bot commented Dec 4, 2025

Copy link
Copy Markdown

@akhilnittala: The label(s) kind/code-refactoring cannot be applied, because the repository doesn't have them.

Details

In response to this:

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
just change in naming convention
Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
GITOPS-7992
Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

anandf
anandf previously approved these changes Dec 4, 2025

@anandf anandf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

olivergondza and others added 4 commits December 5, 2025 13:56
* feat(tests): Add tests for gitops-must-gather

Signed-off-by: Oliver Gondža <[email protected]>

* feat(tests): validate_running_must_gather.go: permit image override

Signed-off-by: Oliver Gondža <[email protected]>

* fix(tests): 1-120_validate_running_must_gather.go: Do not read file to memory + please gosec

Signed-off-by: Oliver Gondža <[email protected]>

* chore(test): Static analysis fixes

Signed-off-by: Oliver Gondža <[email protected]>

* fix(tests): Suppress checking files not present in older ocp versions

Signed-off-by: Oliver Gondža <[email protected]>

---------

Signed-off-by: Oliver Gondža <[email protected]>
Signed-off-by: akhil nittala <[email protected]>
Signed-off-by: akhil nittala <[email protected]>
Signed-off-by: akhil nittala <[email protected]>
Signed-off-by: akhil nittala <[email protected]>
@akhilnittala
akhilnittala force-pushed the usr/akhil/GITOPS_7992 branch from b29dc52 to 870e982 Compare December 5, 2025 08:27
@akhilnittala

Copy link
Copy Markdown
Member Author

/retest-required

@akhilnittala

Copy link
Copy Markdown
Member Author

these changes are made initially for #1027 for 1.17 and #1028 for 1.18

@anandf anandf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandf

anandf commented Dec 9, 2025

Copy link
Copy Markdown
Member

/approve

@anandf

anandf commented Dec 9, 2025

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci

openshift-ci Bot commented Dec 9, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anandf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Dec 9, 2025
@openshift-ci openshift-ci Bot added the lgtm label Dec 9, 2025
@openshift-merge-bot
openshift-merge-bot Bot merged commit 7e3127f into redhat-developer:master Dec 9, 2025
16 checks passed
@akhilnittala
akhilnittala deleted the usr/akhil/GITOPS_7992 branch December 9, 2025 06:24
Naveena-058 pushed a commit to Naveena-058/nas-gitops-operator that referenced this pull request Dec 16, 2025
* feat(tests): Add tests for gitops-must-gather (redhat-developer#958)

* feat(tests): Add tests for gitops-must-gather

Signed-off-by: Oliver Gondža <[email protected]>

* feat(tests): validate_running_must_gather.go: permit image override

Signed-off-by: Oliver Gondža <[email protected]>

* fix(tests): 1-120_validate_running_must_gather.go: Do not read file to memory + please gosec

Signed-off-by: Oliver Gondža <[email protected]>

* chore(test): Static analysis fixes

Signed-off-by: Oliver Gondža <[email protected]>

* fix(tests): Suppress checking files not present in older ocp versions

Signed-off-by: Oliver Gondža <[email protected]>

---------

Signed-off-by: Oliver Gondža <[email protected]>
Signed-off-by: akhil nittala <[email protected]>

* updated naming convention

Signed-off-by: akhil nittala <[email protected]>

* updated naming convention

Signed-off-by: akhil nittala <[email protected]>

* updated naming convention

Signed-off-by: akhil nittala <[email protected]>

---------

Signed-off-by: Oliver Gondža <[email protected]>
Signed-off-by: akhil nittala <[email protected]>
Co-authored-by: Oliver Gondža <[email protected]>
aali309 pushed a commit to aali309/gitops-operator that referenced this pull request Jan 29, 2026
* feat(tests): Add tests for gitops-must-gather (redhat-developer#958)

* feat(tests): Add tests for gitops-must-gather

Signed-off-by: Oliver Gondža <[email protected]>

* feat(tests): validate_running_must_gather.go: permit image override

Signed-off-by: Oliver Gondža <[email protected]>

* fix(tests): 1-120_validate_running_must_gather.go: Do not read file to memory + please gosec

Signed-off-by: Oliver Gondža <[email protected]>

* chore(test): Static analysis fixes

Signed-off-by: Oliver Gondža <[email protected]>

* fix(tests): Suppress checking files not present in older ocp versions

Signed-off-by: Oliver Gondža <[email protected]>

---------

Signed-off-by: Oliver Gondža <[email protected]>
Signed-off-by: akhil nittala <[email protected]>

* updated naming convention

Signed-off-by: akhil nittala <[email protected]>

* updated naming convention

Signed-off-by: akhil nittala <[email protected]>

* updated naming convention

Signed-off-by: akhil nittala <[email protected]>

---------

Signed-off-by: Oliver Gondža <[email protected]>
Signed-off-by: akhil nittala <[email protected]>
Co-authored-by: Oliver Gondža <[email protected]>
Signed-off-by: Atif Ali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants