updated naming convention - #1026
Conversation
|
@akhilnittala: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* feat(tests): Add tests for gitops-must-gather Signed-off-by: Oliver Gondža <[email protected]> * feat(tests): validate_running_must_gather.go: permit image override Signed-off-by: Oliver Gondža <[email protected]> * fix(tests): 1-120_validate_running_must_gather.go: Do not read file to memory + please gosec Signed-off-by: Oliver Gondža <[email protected]> * chore(test): Static analysis fixes Signed-off-by: Oliver Gondža <[email protected]> * fix(tests): Suppress checking files not present in older ocp versions Signed-off-by: Oliver Gondža <[email protected]> --------- Signed-off-by: Oliver Gondža <[email protected]> Signed-off-by: akhil nittala <[email protected]>
Signed-off-by: akhil nittala <[email protected]>
Signed-off-by: akhil nittala <[email protected]>
Signed-off-by: akhil nittala <[email protected]>
b29dc52 to
870e982
Compare
|
/retest-required |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anandf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7e3127f
into
redhat-developer:master
* feat(tests): Add tests for gitops-must-gather (redhat-developer#958) * feat(tests): Add tests for gitops-must-gather Signed-off-by: Oliver Gondža <[email protected]> * feat(tests): validate_running_must_gather.go: permit image override Signed-off-by: Oliver Gondža <[email protected]> * fix(tests): 1-120_validate_running_must_gather.go: Do not read file to memory + please gosec Signed-off-by: Oliver Gondža <[email protected]> * chore(test): Static analysis fixes Signed-off-by: Oliver Gondža <[email protected]> * fix(tests): Suppress checking files not present in older ocp versions Signed-off-by: Oliver Gondža <[email protected]> --------- Signed-off-by: Oliver Gondža <[email protected]> Signed-off-by: akhil nittala <[email protected]> * updated naming convention Signed-off-by: akhil nittala <[email protected]> * updated naming convention Signed-off-by: akhil nittala <[email protected]> * updated naming convention Signed-off-by: akhil nittala <[email protected]> --------- Signed-off-by: Oliver Gondža <[email protected]> Signed-off-by: akhil nittala <[email protected]> Co-authored-by: Oliver Gondža <[email protected]>
* feat(tests): Add tests for gitops-must-gather (redhat-developer#958) * feat(tests): Add tests for gitops-must-gather Signed-off-by: Oliver Gondža <[email protected]> * feat(tests): validate_running_must_gather.go: permit image override Signed-off-by: Oliver Gondža <[email protected]> * fix(tests): 1-120_validate_running_must_gather.go: Do not read file to memory + please gosec Signed-off-by: Oliver Gondža <[email protected]> * chore(test): Static analysis fixes Signed-off-by: Oliver Gondža <[email protected]> * fix(tests): Suppress checking files not present in older ocp versions Signed-off-by: Oliver Gondža <[email protected]> --------- Signed-off-by: Oliver Gondža <[email protected]> Signed-off-by: akhil nittala <[email protected]> * updated naming convention Signed-off-by: akhil nittala <[email protected]> * updated naming convention Signed-off-by: akhil nittala <[email protected]> * updated naming convention Signed-off-by: akhil nittala <[email protected]> --------- Signed-off-by: Oliver Gondža <[email protected]> Signed-off-by: akhil nittala <[email protected]> Co-authored-by: Oliver Gondža <[email protected]> Signed-off-by: Atif Ali <[email protected]>
What type of PR is this?
What does this PR do / why we need it:
just change in naming convention
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
GITOPS-7992
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: