feat: Clickable Profile card and Our Project redirection to main repo#131
Merged
Conversation
Contributor
|
@harish599 is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
harish599
changed the title
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces clickable interactions for the profile card on the homepage and the project tag in the OurProjects component, redirecting users to external URLs.
- Added onClick handler and cursor style to the homepage profile card for redirection
- Made the project tag in OurProjects clickable, linking to the GitHub repository
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/pages/index.tsx | Wrapped profile image container in a clickable div |
| src/components/ourProjects.tsx | Added onClick and cursor-pointer to the tag element |
Comment on lines
+61
to
70
| <div | ||
| className="m-4" | ||
| onClick={() => (window.location.href = "https://www.sanjaykv.com/")} | ||
| > | ||
| <img | ||
| src="/selfhero.png" | ||
| alt="recodehive" | ||
| className="w-full h-full object-cover rounded-2xl" | ||
| className="w-full h-full object-cover rounded-2xl cursor-pointer" | ||
| /> | ||
| </div> |
There was a problem hiding this comment.
Directly setting window.location.href bypasses SPA routing and may reload the entire app. Consider using Next.js or a routing utility to maintain client-side navigation.
Comment on lines
+63
to
70
| <div | ||
| className="cursor-pointer px-6 py-2 bg-gradient-to-r from-blue-500 to-purple-500 text-white rounded-full text-sm sm:text-base font-medium tracking-wide shadow-lg transform hover:scale-105 transition-transform duration-300" | ||
| onClick={() => | ||
| (window.location.href = "https://github.com/recodehive") | ||
| } | ||
| > | ||
| {tag} | ||
| </div> |
There was a problem hiding this comment.
Wrapping the tag in a clickable
without semantic elements or keyboard support can harm accessibility. Use an or , or add role="button", tabIndex, and keyboard event handlers.
Suggested change
| <div | |
| className="cursor-pointer px-6 py-2 bg-gradient-to-r from-blue-500 to-purple-500 text-white rounded-full text-sm sm:text-base font-medium tracking-wide shadow-lg transform hover:scale-105 transition-transform duration-300" | |
| onClick={() => | |
| (window.location.href = "https://github.com/recodehive") | |
| } | |
| > | |
| {tag} | |
| </div> | |
| <a | |
| href="https://github.com/recodehive" | |
| className="cursor-pointer px-6 py-2 bg-gradient-to-r from-blue-500 to-purple-500 text-white rounded-full text-sm sm:text-base font-medium tracking-wide shadow-lg transform hover:scale-105 transition-transform duration-300" | |
| > | |
| {tag} | |
| </a> |
Comment on lines
+63
to
70
| <div | ||
| className="cursor-pointer px-6 py-2 bg-gradient-to-r from-blue-500 to-purple-500 text-white rounded-full text-sm sm:text-base font-medium tracking-wide shadow-lg transform hover:scale-105 transition-transform duration-300" | ||
| onClick={() => | ||
| (window.location.href = "https://github.com/recodehive") | ||
| } | ||
| > | ||
| {tag} | ||
| </div> |
There was a problem hiding this comment.
Manipulating window.location.href directly triggers a full page reload. Consider using a proper link component or routing helper to preserve single-page app behavior.
Suggested change
| <div | |
| className="cursor-pointer px-6 py-2 bg-gradient-to-r from-blue-500 to-purple-500 text-white rounded-full text-sm sm:text-base font-medium tracking-wide shadow-lg transform hover:scale-105 transition-transform duration-300" | |
| onClick={() => | |
| (window.location.href = "https://github.com/recodehive") | |
| } | |
| > | |
| {tag} | |
| </div> | |
| <a | |
| href="https://github.com/recodehive" | |
| target="_blank" | |
| rel="noopener noreferrer" | |
| className="cursor-pointer px-6 py-2 bg-gradient-to-r from-blue-500 to-purple-500 text-white rounded-full text-sm sm:text-base font-medium tracking-wide shadow-lg transform hover:scale-105 transition-transform duration-300" | |
| > | |
| {tag} | |
| </a> |
sanjay-kv
approved these changes
Jun 20, 2025
Member
|
Thanks @harish599 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for issues #128 and #127