issue-938: added sections in serialization for simple file, csv, yaml and json#947
Merged
Conversation
Contributor
|
@harishkrao I'm happy with it so far 👍 |
Author
|
Thank you @mpoulin, I will add the remaining changes as well. |
Author
|
Hi @mpoulin, I have added the remaining changes. Please let me know if they look fine to merge. Thank you for providing feedback. |
apjanke
suggested changes
Dec 18, 2018
Contributor
apjanke
left a comment
apjanke
left a comment
There was a problem hiding this comment.
A couple style suggestions.
Author
Author
|
Hi @mpoulin, just checking in to see if everything looks good for the branch to be merged to master. Thank you in advance. |
Contributor
|
Thanks @harishkrao . I will look at this today or tomorrow. |
mpoulin
reviewed
Dec 20, 2018
mpoulin
reviewed
Dec 20, 2018
mpoulin
reviewed
Dec 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mpoulin, can you please look at my pull request and confirm if everything in it looks fine? I am currently working on the remaining sections of this topic and in the meantime, I wanted to run this by you or Dan to see if any changes are required to the existing structure. Thanks in advance.