Added windows virtual environment activation command. Closes #942 by suryasr007 · Pull Request #946 · realpython/python-guide

suryasr007 · 2018-12-16T13:42:05Z

Issue: 942

Add windows virtual environment activation command.

Additional Changes

Defined venv as name of virtual environment, Instead of my_project.
Provided details about python's virtual environment module venv

mpoulin · 2018-12-17T15:55:59Z

@suryasr007
Thanks for making these edits.
Is there a benefit to naming the environment "venv" instead of "my_project"?

suryasr007 · 2018-12-17T17:02:15Z

Hi @mpoulin,

As I mentioned in guide, 'venv' is the general convention used globally. As it is readily available in ignore files (eg: .gitignore').

apjanke

A couple minor typo/style notes.

apjanke · 2018-12-18T06:27:03Z

-placed in the ``my_project`` folder, isolated from the global Python installation.
+placed in the ``venv`` folder, isolated from the global Python installation.
+
+For windows, same command which is mentioned in step 1 can be used for creation of virtual environment. But, to activate, we use the following command.


"Windows" should be capitalized.

Thanks for pointing out. I will change it.

apjanke · 2018-12-18T06:27:14Z

+
+For windows, same command which is mentioned in step 1 can be used for creation of virtual environment. But, to activate, we use the following command.
+
+Assuming that, you are in project directory:


Typo: no comma necessary here.

Thanks for pointing out. I will change it.

apjanke · 2018-12-18T06:27:50Z

 where they were placed.

+.. note::
+    Python has included virtual environment module from 3.3. It works in the simliar way as mentioned above. For details: `venv <https://docs.python.org/3/library/venv.html>`_.


Typo: "similar".

Should probably also be "...included the virtual...".

Can you please elaborate this?

This is just an English grammar issue, I think. For a non-proper noun "foo", if you say "X has included foo", it really needs an article like "X has include a foo" or "X has included the foo". Plain "X has included foo" only works for proper nouns/names of the form "X has included Foo" For that form, it would be "Python has included venv from 3.3.". That would be okay since "venv" is a proper noun since it's the actual name of the module.

Thanks @apjanke for the clarification.

suryasr007 · 2018-12-18T19:24:31Z

HI @apjanke
Fixed the typos

apjanke · 2018-12-18T20:59:04Z

Looks good to me now.

suryasr007 · 2018-12-20T15:54:16Z

on windows I thinkthis should be venv\Scripts\activate

Yeah, sorry my bad. I will rectify that.
Thanks for pointing out.

Added windows virtual environment activation command. Closes #942

af99710

apjanke suggested changes Dec 18, 2018

View reviewed changes

Surya Teja Reddy Valluri added 3 commits December 18, 2018 22:30

Merge branch 'master' of https://github.com/realpython/python-guide

fb856c1

Fixed typos/grammer

7022a9f

small typo

179493d

Surya Teja Reddy Valluri added 2 commits December 20, 2018 21:28

Merge branch 'master' of https://github.com/realpython/python-guide

a5eb4ca

Fixed Scripts issue

dc85a33

mpoulin merged commit 9d975b5 into realpython:master Dec 20, 2018


		For windows, same command which is mentioned in step 1 can be used for creation of virtual environment. But, to activate, we use the following command.

		Assuming that, you are in project directory:

Conversation

suryasr007 commented Dec 16, 2018

Uh oh!

mpoulin commented Dec 17, 2018

Uh oh!

suryasr007 commented Dec 17, 2018

Uh oh!

apjanke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suryasr007 commented Dec 18, 2018

Uh oh!

apjanke commented Dec 18, 2018

Uh oh!

suryasr007 commented Dec 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants