[fix search website] Changing the position of the script (not included)#934
Merged
kennethreitz merged 6 commits intoNov 7, 2018
Merged
Conversation
Member
|
@s-pace Thanks, I guess we were a little too eager to get the previous PR merged :-) Seeing some JS console errors and the search box doesn't seem to work:
By the way, you can preview your changes by clicking the green checkmark next to each commit and clicking the "details" button next to the Netlify build step:
|
Contributor
|
sorry about that! |
Contributor
Author
|
Weird, I have created an input matching #q. |
added 2 commits
November 7, 2018 18:05
Member
|
@s-pace Cool—can you change the placeholder on the search input to "Search the Guide"? Then we're ready to go I think! |
Member
|
And ideally the search input should take up 100% of the navbar width to match the rest of the content there. |
Member
|
Got some issue with the styles now:
|
Contributor
Author
|
I will inject the css in the same file. |
s-pace
force-pushed
the
www/fix/search_script_position
branch
from
4da8230 to
f526118
Compare
s-pace
force-pushed
the
www/fix/search_script_position
branch
from
68f3702 to
18df25b
Compare
Contributor
Author
|
Ready to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#933 fixed
#932
cc @dbader