Logging section#512
Conversation
There was a problem hiding this comment.
Please remove "Do that."
|
Thanks @tanyaschlusser! This is a good start. Please take care of the feedback I left you and ping me when you're done (GitHub doesn't notify me when you've added more commits to the PR). 🎉 |
|
Thank you @sigmavirus24 ! All of the changes except for the :pep: |
There was a problem hiding this comment.
Two last nits:
- Can you make the Pro/Con emphasis bold instead of italic?
- The
--doesn't show up as an emdash (which is what I think you were shooting for), can you just use a:?
After that, LGTM.
There was a problem hiding this comment.
Thank you for reviewing @sigmavirus24 -- Done!
|
OK, all changes have been pushed, thank you! |
|
Thank you @tanyaschlusser !!!! 🍰 ✨ |
|
Yay! sorry I should have noticed that |
There was a problem hiding this comment.
logging_config.txt should be logging_config.ini
sorry
There was a problem hiding this comment.
Woops! You have to make a new PR with that. Sorry for the hassle
There was a problem hiding this comment.
I made the change myself @tanyaschlusser to save you some trouble
|
Thank you @sigmavirus24 ! |
2 participants
This is in reference to Issue 336 -- No section on logging?
It is a first attempt, written in a separate file, and inserted between the Testing and Gotchas section on the Writing page. Thank you for suggestions!