Improve upon @royka's initial JSON section#508
Closed
mplewis wants to merge 3 commits into
Closed
Conversation
Contributor
|
Thanks for the work, I'll take a look! |
Contributor
Author
|
Hey @sigmavirus24, I can do that. Can you please explain to me why, though? Since it seems you are the maintainer of the project and the one approving changes, not @royka, I thought it was appropriate to submit a PR for you to review directly. |
Contributor
Author
|
@royka: I'll submit a PR in one sec! Thanks again. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @royka! Thanks for the work you put into building an initial JSON guide in #507.
I took your work and incorporated some of the suggestions made by @sigmavirus24. Please take a look and let me know what you think.