Skip to content

add initial JSON section#507

Merged
kennethreitz merged 1 commit into
realpython:masterfrom
samjacobclift:add_json_section
Jan 9, 2015
Merged

add initial JSON section#507
kennethreitz merged 1 commit into
realpython:masterfrom
samjacobclift:add_json_section

Conversation

@samjacobclift
Copy link
Copy Markdown

Still a work in progress for this issue. Please comment and review

Be gentle my first pull request

@samjacobclift
Copy link
Copy Markdown
Author

Here is the issue https://github.com/kennethreitz/python-guide/issues/150

As said in the comments there, lets get something going and then we can discuss what should go in

@samjacobclift samjacobclift mentioned this pull request Dec 11, 2014
Comment thread docs/scenarios/json.rst
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should note that it was added in 2.6. There's simplejson on PyPI for all older versions (since there are disappointingly still a lot of people using 2.4 and 2.5)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh ok maybe simple JSON doesn't need to be a separate section then? Could roll it all into one section. With a foot note explaining what simple JSON is

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your later statement that it's still maintained/released is true. I wasn't aware of that. Leave the extra section for now. I have research to do ;)

@mplewis
Copy link
Copy Markdown
Contributor

mplewis commented Dec 16, 2014

Hey @royka! Thanks for the work you put into this. I've been building on it in the PR linked above.

kennethreitz added a commit that referenced this pull request Jan 9, 2015
@kennethreitz kennethreitz merged commit de9c370 into realpython:master Jan 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants