Avoid warning when catching signal with pcntl_signal() - #297

Symfony's implementation is quite similar but more precise I think. See implementation at https://github.com/symfony/symfony/blob/27e1a893a090bf58bce774660f6cb5cbdfd4d287/src/Symfony/Component/Process/ProcessPipes.php#L359-L365 and usage at https://github.com/symfony/symfony/blob/27e1a893a090bf58bce774660f6cb5cbdfd4d287/src/Symfony/Component/Process/ProcessPipes.php#L235-L241

Great idea, but they use the prefix @, and I wanted to avoid it due to low performance of this trick.

I'm curious about what low performance you're speaking. Symfony's code bypasses the error and check if it was a interrupted system call only if stream_select returned false whereas your implementation switches the error handler twice for every call. It's definitely not a such low performance trick :)

I was not saying my fix is more efficient than another. I just tried to avoid the @ trigger.
Moreover, I didn't know about the false return statement on error of the function stream_select, so the Symfony's fix is clearly better.
I can't fix it this PR today. I'll do the change tomorrow :)

no worries. Avoid the use of @ when it's about dicarding errors when they should not be, but in this case we just filter errors that could be safely discarded.
thanks for your work

Fixes are available as @romainneutron advised. I saw a bug only after some commit sorry.

Works like a charm. When does it get merged back?

@clue I've my locale set to french and the message is still in english.

When is it planned to get merged?

Why not merged yet?

This is now a read-only repo made up of components loaded from composer. Merge requests need to made against the event-loop. In addition, I wouldn't want to include @stream_select in the source code. stream_select is the core of the EventLoop and error suppression is detrimental to performance.

Right, supressing errors is bad for performance, especially inside the event-loop. I wouldn't put this into the core either. But there should be a way out for users. Maybe a special subclass or at least a hint in the docs.

Regarding the check for the return-value: this should definitely be merged. If the stream_select-call fails, you should not rely on the references.

Try use declare(ticks=1); on top in root file. Then you can catch signals without errors/warnings.

I am pretty sure this will slow down your app considerably.

On Wed, Jun 10, 2015 at 7:51 AM, Kamil Harasimowicz <
[email protected]> wrote:

Try use declare(ticks=1); on top in root file. Then you can catch signals
without errors/warnings.

—
Reply to this email directly or view it on GitHub
#297 (comment).

Probably yes but in many cases it might not be as critical, and will work without problems.