Skip to content

Make the shadow root optional #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackfranklin merged 1 commit into from
Feb 14, 2019
Merged

Make the shadow root optional #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,18 @@ Subscribing to DOM events is similar:
React.findDOMNode(this).addEventListener('change', function(e){...});
```

## Options

You can also specify options to the `ReactiveElements` call, e.g.

```js
ReactiveElements('welcome-component', Welcome, options);
```

### `options.useShadowDom` _(default `false`)_

By default, your React element is rendered directly into the web-component root. However, by setting this option - your React element will instead be rendered in a [Shadow DOM](https://developer.mozilla.org/en-US/docs/Web/Web_Components/Using_shadow_DOM) inside the web-component instead.

## Dependencies

- [React.js](https://github.com/facebook/react)
Expand Down
17 changes: 13 additions & 4 deletions src/reactive-elements.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,20 @@ import * as utils from './utils';
import * as React from 'react';
import * as ReactDOM from 'react-dom';

const getRenderRoot = (element, useShadowDom) =>
useShadowDom ? element.shadowRoot : element;

function reactiveElements(elementName, ReactComponent, options) {
const { useShadowDom = false } = options;

function create(parent, props) {
var element = React.createElement(ReactComponent, props);
parent.reactiveElement = element;
return ReactDOM.render(element, parent.shadowRoot, props.onRender);
return ReactDOM.render(
element,
getRenderRoot(parent, useShadowDom),
props.onRender
);
}

function exposeDefaultMethods(reactComponent, customElement) {
Expand All @@ -21,10 +30,10 @@ function reactiveElements(elementName, ReactComponent, options) {
constructor() {
const self = super();

self.attachShadow({ mode: 'open' });
if (useShadowDom) self.attachShadow({ mode: 'open' });

const observer = new MutationObserver(() => {
ReactDOM.unmountComponentAtNode(self.shadowRoot);
ReactDOM.unmountComponentAtNode(getRenderRoot(self, useShadowDom));
const props = utils.getProps(self);
props.children = utils.getChildren(self);
create(self, props);
Expand Down Expand Up @@ -61,7 +70,7 @@ function reactiveElements(elementName, ReactComponent, options) {
}

disconnectedCallback() {
ReactDOM.unmountComponentAtNode(this.shadowRoot);
ReactDOM.unmountComponentAtNode(getRenderRoot(this, useShadowDom));
}
}

Expand Down