Skip to content

Commit ba418ce

Browse files
test: stop swallowing exception in ITAddressesTest.insertAddress (googleapis#10020)
* test: stop swallowing exception in ITAddressesTest.insertAddress Fixes: googleapis#9890. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent e336c70 commit ba418ce

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

‎java-compute/README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ If you are using Maven with [BOM][libraries-bom], add this to your pom.xml file:
2020
<dependency>
2121
<groupId>com.google.cloud</groupId>
2222
<artifactId>libraries-bom</artifactId>
23-
<version>26.19.0</version>
23+
<version>26.26.0</version>
2424
<type>pom</type>
2525
<scope>import</scope>
2626
</dependency>
@@ -260,7 +260,7 @@ Java is a registered trademark of Oracle and/or its affiliates.
260260
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/java11.html
261261
[stability-image]: https://img.shields.io/badge/stability-stable-green
262262
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-compute.svg
263-
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-compute/1.32.0
263+
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-compute/1.39.0
264264
[authentication]: https://github.com/googleapis/google-cloud-java#authentication
265265
[auth-scopes]: https://developers.google.com/identity/protocols/oauth2/scopes
266266
[predefined-iam-roles]: https://cloud.google.com/iam/docs/understanding-roles#predefined_roles

‎java-compute/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/integration/ITAddressesTest.java‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
*/
1616
package com.google.cloud.compute.v1.integration;
1717

18-
import static org.junit.Assert.fail;
19-
2018
import com.google.cloud.compute.v1.Address;
2119
import com.google.cloud.compute.v1.AddressesClient;
2220
import com.google.cloud.compute.v1.AddressesScopedList;
@@ -120,7 +118,7 @@ private void insertAddress(String description) {
120118
.insertAsync(DEFAULT_PROJECT, DEFAULT_REGION, address)
121119
.get(60, TimeUnit.SECONDS);
122120
} catch (InterruptedException | ExecutionException | TimeoutException e) {
123-
fail("Insert operation failed.");
121+
throw new RuntimeException("Insert operation failed.", e);
124122
}
125123
addresses.add(address);
126124
}

0 commit comments

Comments
 (0)