Skip to content

Fix handling of color for labels#70

Merged
petercorke merged 1 commit intorai-opensource:masterfrom
stefangachter:fix_label_color
Mar 28, 2023
Merged

Fix handling of color for labels#70
petercorke merged 1 commit intorai-opensource:masterfrom
stefangachter:fix_label_color

Conversation

@stefangachter
Copy link
Copy Markdown
Contributor

According to the description, the color for origin and axis labels should default to color. However,

  • if origin color is defined without a frame label, then origin color is ignored
  • if a frame label is given, then the color is set to blue for origin and axis labels
X = SE3.Rand()
X.plot(color=["r","g","b"], textcolor="k", origincolor="k", style="line")

image
X.plot(frame="A", color=["r","g","b"], textcolor="k", origincolor="k", style="line")
image
There was some "code duplication".

@stefangachter
Copy link
Copy Markdown
Contributor Author

stefangachter commented Mar 21, 2023

Note, this fix is slightly different from #58 and #67. It considers color of origin as well.

@petercorke
Copy link
Copy Markdown
Collaborator

will this resolve the issues with #67 and #69 as well? This might as well all go out in 1.1.6 soon, am keen to push the r2q fix.

@stefangachter
Copy link
Copy Markdown
Contributor Author

Yes, this will fix #67 but not #69. #69 is a different issue.

@petercorke petercorke merged commit 807c483 into rai-opensource:master Mar 28, 2023
@stefangachter stefangachter deleted the fix_label_color branch March 30, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants