Fix division by scalar for Twist2 classes#46
Closed
btalb wants to merge 0 commit intorai-opensource:masterfrom
Closed
Fix division by scalar for Twist2 classes#46btalb wants to merge 0 commit intorai-opensource:masterfrom
Twist2 classes#46btalb wants to merge 0 commit intorai-opensource:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Division by a scalar works for
Twist3classes, but throws this error forTwist2classes:The error is caused by
__truediv__()in theBaseTwistclass returning aTwist3()instance when divided by a scalar, rather than a type corresponding to theleftparam.This PR fixes this.