Consumer trait#22
Merged
makasim merged 2 commits intoqueue-interop:0.7from Nov 20, 2018
sylfabre:patch-2-consumer
Merged
Conversation
Member
|
@sylfabre Could you please rebase, cuz I've merged message trait cherry pick to 0.7 |
makasim
reviewed
Oct 19, 2018
| /** | ||
| * The ConsumerPollingTrait is a common implementation of the polling algorithm for a Consumer | ||
| */ | ||
| trait ConsumerPollingTrait |
Member
There was a problem hiding this comment.
I would love to merge this trait and its tests. Could you make a separate PR with only this one?
Contributor
Author
|
@makasim I've updated the PR with the last 0.7 version |
|
Hello ! I'm working on the azure integration of php-enqueue (php-enqueue/enqueue-dev#645 it'd be great if you could tell me if I can rely on this trait for my dev, could you tell me if you plan to merge this PR anytime soon ? |
Member
|
@PaulRouss3l I've just merged it, you could rely on it |
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.