Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: iamkinetic/NEventSocket
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: questnet/NEventSocket
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: questnet
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 9 files changed
  • 2 contributors

Commits on Nov 13, 2024

  1. Avoid "index out of range" exceptions when empty error responses are … 

    …returned.
    @ajgolledge
    ajgolledge committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    53ad61a View commit details
    Browse the repository at this point in the history

  2. The BasicMessage class now takes a byte array as a parameter instead … 

    …of a UTF-8 string. This byte array is then used for further parsing in the derived EventMessage class to save converting back again to a byte array from a UTF-8 string. Tests have been extended to include a DetectedSpeech event. There are two variants of this event which are used in the tests, one containing a response with English text in the body and another containing German text and umlaut characters. Add Logger initializer to MessageParsingTests class to allow its test cases to be run independently. Add new test case to MessageParsingTests to test for the successful extraction of body payload from the EventMessage.
    @entenschnabel @ajgolledge
    entenschnabel authored and ajgolledge committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    763707d View commit details
    Browse the repository at this point in the history

  3. Fix Parser.Append(byte[]) which was recursing.

    @ajgolledge
    ajgolledge committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    804a0b9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'error-response-index-failure' into questnet

    @ajgolledge
    ajgolledge committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    93dfb8b View commit details
    Browse the repository at this point in the history

  5. Update unit tests to work on byte arrays rather than strings.

    @ajgolledge
    ajgolledge committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    e6b72d0 View commit details
    Browse the repository at this point in the history

  6. Update package information, including version number.

    @ajgolledge
    ajgolledge committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c21d212 View commit details
    Browse the repository at this point in the history
Loading