theme helper functions - #9
Merged
gordonwoodhull merged 4 commits intoMay 5, 2025
Merged
Conversation
Member
Author
|
This PR also changes the license to MIT, because we want people to feel very free to copy these helpers and improve them for their own purposes. |
gordonwoodhull
marked this pull request as ready for review
May 5, 2025 21:18
temporary - will move to quartodoc later
gordonwoodhull
force-pushed
the
feature/theme-helpers
branch
from
May 5, 2025 21:22
17f86e2 to
3c7cbe9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are helper functions for about eight Python plotting and table packages.
Companion to quarto-dev/quarto-r#234 for R packages
The corresponding adapted examples are on the
quarto-helpersbranch,helpers/directory of myquarto-light-dark-experimentsrepo:https://github.com/gordonwoodhull/quarto-light-dark-experiments/tree/use-quarto-helpers/helpers
naming convention
Following the naming convention from
quarto-r, I have adoptedtheme_colors_{package}bg,fgtheme_brand_{package}brand_ymlA couple of these functions that also take a primary and/or secondary color. That's not something we're trying to support, but a pointer of where advanced users could take this.
Conventions are all over the board as to what is appropriate to return and how it will be used. (Theming is the most idiomatic thing you can do with any package. 😉 )
We need to find a home for the examples
quarto-light-dark-experiments. Maybe inquarto-examples? But this would add a lot of dependencies.As always, I'm open to all design suggestions. Note that these aren't really Quarto functions; they are adaptors to help use other packages with Quarto.