Repository navigation
JNI: reuse protocol parameter adapters across overloads - #9
Merged
teamhimeh merged 1 commit intoOct 23, 2026
Merged
Conversation
teamhimeh
force-pushed
the
codex/fix-jni-protocol-parameter-overloads
branch
from
October 23, 2026 07:58
769e5d4 to
e133956
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
JNI extraction emits a protocol-parameter adapter for each function declaration. Overloads with the same function name, parameter name, and enclosing type can require the same adapter, so the generated Swift contains duplicate class declarations and fails to compile.
For example, both initializers below generate the same adapter for
store:With this change, that adapter is emitted once and both initializers reuse it. The same applies to overloaded instance methods and free functions.
Changes
Validation
swift test --disable-experimental-prebuilts --disable-sandbox --filter JNIProtocol: 27 tests passed../gradlew :Samples:SwiftJavaExtractJNISampleApp:test --no-daemon: all Java tests passed, including the new callback round trips.swift-formatandgit diff --checkpassed.Tested with Apple Swift 6.4 and JetBrains Runtime 25 on macOS.