Repository navigation
wrap-java: qualify Optional convenience method calls with self - #8
Merged
teamhimeh merged 1 commit intoOct 23, 2026
Merged
Conversation
teamhimeh
force-pushed
the
codex/fix-wrap-java-optional-method-calls
branch
from
October 23, 2026 07:58
09b806f to
6e80f20
Compare
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Optional convenience methods generated by
wrap-javainvoke the original method without a receiver. A parameter can therefore shadow that method and make the generated Swift fail to compile.For example, this Java declaration:
produces a Swift convenience method whose argument is also named
arg0:The body attempts to call the Optional argument as a function. With this change, it explicitly calls the original method:
Changes
self.Validation
swift test --disable-experimental-prebuilts --disable-sandbox: full Swift test suite passed.swift-formatandgit diff --checkpassed.Tested with Apple Swift 6.4 and JetBrains Runtime 25 on macOS.