Repository navigation
wrap-java: synchronize checked-in generated wrapper outputs - #13
Merged
Merged
Conversation
Collaborator
Author
|
When posted to upstream,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The checked-in Java standard-library wrappers still emit unqualified Optional convenience calls, while the generator now emits
self-qualified calls. Regeneration therefore changes ten tracked files, causing theJavaStdlib wrap-java up-to-datecheck to fail.Regenerating runtime support also creates
generated/JavaUtilUUID.swiftalongside the hand-writtenJavaUtilUUID.swift. A subsequent Swift build fails because the same filename and projection are defined twice.Changes
self.Validation
./scripts/wrap-java-generate.shcompleted; repeating regeneration produced no tracked output changes, including with the CI whitespace-tolerant diff check.swift test --disable-experimental-prebuilts --disable-sandbox: full Swift test suite passed after regeneration../gradlew :Samples:SwiftJavaExtractJNISampleApp:test --tests '*FoundationCallbackTest' --no-daemon: all five Foundation callback tests passed, including UUID round trips using the generated projection.swift-format lint --stricton the new generated projection andgit diff --checkpassed.Tested with Apple Swift 6.4 and JetBrains Runtime 25 on macOS.