Alphabetize attributes for no good reason

paul-griffith · paul-griffith · commit d2de25dbf8af · 2019-06-25T10:09:44.000-07:00
diff --git a/slack/web/classes/actions.py b/slack/web/classes/actions.py
@@ -46,7 +46,7 @@ def to_dict(self) -> dict:
 class ActionButton(Action):
     @property
     def attributes(self):
-        return super().attributes.union({"value", "style"})
+        return super().attributes.union({"style", "value"})
 
     value_max_length = 2000
 
@@ -117,7 +117,7 @@ def __init__(self, *, text: str, url: str):
 class AbstractActionSelector(Action, metaclass=ABCMeta):
     DataSourceTypes = DynamicSelectElementTypes.union({"external", "static"})
 
-    attributes = {"name", "text", "type", "data_source"}
+    attributes = {"data_source", "name", "text", "type"}
 
     @property
     @abstractmethod
diff --git a/slack/web/classes/attachments.py b/slack/web/classes/attachments.py
@@ -5,11 +5,11 @@
 from .actions import Action
 from .blocks import Block
 
-SeededColors = {"good", "warning", "danger"}
+SeededColors = {"danger", "good", "warning"}
 
 
 class AttachmentField(JsonObject):
-    attributes = {"short", "value", "title"}
+    attributes = {"short", "title", "value"}
 
     def __init__(
         self,
@@ -25,27 +25,27 @@ def __init__(
 
 class Attachment(JsonObject):
     attributes = {
-        "title",
-        "pretext",
+        "author_icon",
+        "author_link",
+        "author_name",
         "color",
-        "text",
-        "ts",
         "fallback",
+        "fields",
         "footer",
-        "thumb_url",
         "footer_icon",
-        "author_icon",
-        "author_name",
-        "author_link",
-        "fields",
-        "title_link",
         "image_url",
+        "pretext",
+        "text",
+        "thumb_url",
+        "title",
+        "title_link",
+        "ts",
     }
 
     fields: List[AttachmentField]
     actions: List[Action]
 
-    MarkdownFields = {"pretext", "text", "fields"}
+    MarkdownFields = {"fields", "pretext", "text"}
 
     footer_max_length = 300
 
diff --git a/slack/web/classes/blocks.py b/slack/web/classes/blocks.py
@@ -93,7 +93,7 @@ def to_dict(self) -> dict:
 class ImageBlock(Block):
     @property
     def attributes(self) -> Set[str]:
-        return super().attributes.union({"image_url", "alt_text"})
+        return super().attributes.union({"alt_text", "image_url"})
 
     image_url_max_length = 3000
     alt_text_max_length = 2000
diff --git a/slack/web/classes/dialog_elements.py b/slack/web/classes/dialog_elements.py
@@ -9,16 +9,16 @@
 
 class DialogTextComponent(JsonObject, metaclass=ABCMeta):
     attributes = {
-        "optional",
-        "name",
         "hint",
+        "label",
         "max_length",
-        "value",
-        "placeholder",
         "min_length",
-        "label",
+        "name",
+        "optional",
+        "placeholder",
         "subtype",
         "type",
+        "value",
     }
 
     name_max_length = 300
@@ -137,7 +137,7 @@ class DialogTextArea(DialogTextComponent):
 class AbstractDialogSelector(JsonObject, metaclass=ABCMeta):
     DataSourceTypes = DynamicSelectElementTypes.union({"external", "static"})
 
-    attributes = {"name", "label", "optional", "placeholder", "type", "data_source"}
+    attributes = {"data_source", "label", "name", "optional", "placeholder", "type"}
 
     name_max_length = 300
     label_max_length = 48
diff --git a/slack/web/classes/dialogs.py b/slack/web/classes/dialogs.py
@@ -17,6 +17,8 @@
 
 
 class DialogBuilder(JsonObject):
+    attributes = {}  # no attributes because to_dict has unique implementation
+
     _callback_id: Optional[str]
     _elements: List[Union[DialogTextComponent, AbstractDialogSelector]]
     _submit_label: Optional[str]
diff --git a/slack/web/classes/elements.py b/slack/web/classes/elements.py
@@ -39,7 +39,7 @@ def action_id_length(self):
 class ImageElement(BlockElement):
     @property
     def attributes(self) -> Set[str]:
-        return super().attributes.union({"image_url", "alt_text"})
+        return super().attributes.union({"alt_text", "image_url"})
 
     image_url_max_length = 3000
     alt_text_max_length = 2000
@@ -75,7 +75,7 @@ def alt_text_length(self):
 class ButtonElement(InteractiveElement):
     @property
     def attributes(self) -> Set[str]:
-        return super().attributes.union({"value", "style"})
+        return super().attributes.union({"style", "value"})
 
     text_max_length = 75
     value_max_length = 75
@@ -181,7 +181,7 @@ def __init__(
     def placeholder_length(self):
         return len(self.placeholder) <= self.placeholder_max_length
 
-    def to_dict(self, ) -> dict:
+    def to_dict(self,) -> dict:
         json = super().to_dict()
         json["placeholder"] = PlainTextObject.direct_from_string(self.placeholder)
         if self.confirm is not None:
diff --git a/slack/web/classes/objects.py b/slack/web/classes/objects.py
@@ -3,8 +3,8 @@
 
 from . import BaseObject, JsonObject, JsonValidator, extract_json
 
-ButtonStyles = {"primary", "danger"}
-DynamicSelectElementTypes = {"users", "channels", "conversations"}
+ButtonStyles = {"danger", "primary"}
+DynamicSelectElementTypes = {"channels", "conversations", "users"}
 
 
 class Link(BaseObject):
