You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Seeking Feedback for Potential PR: Method Binder IsAssignable From #529
The plan would be to make the generic-locator code more effective.
mhandschuh [4:11 PM]
I would recommend looking at the MethodBinder -- it appears to be matching directly on type and not using Type.IsAssignableFrom which should properly handle super types (going from SimpleMovingAverage to IndicatorBase)
We're not really sure the flow on impacts for the whole library -- is this feasible; or are other parts of the code dependent on this = statement?
changed the title [-]Suggestion / Seeking Feedback for Potential PR:[/-][+]Seeking Feedback for Potential PR: Method Binder IsAssignable From[/+]on Aug 25, 2017
Activity
[-]Suggestion / Seeking Feedback for Potential PR:[/-][+]Seeking Feedback for Potential PR: Method Binder IsAssignable From[/+]mchandschuh commentedon Aug 25, 2017
My python skills are severely lacking, so I'll just ask here.
Is there a test that verifies derived types can be passed as arguments to functions?
Does pythonnet support invoking the
AcceptsBaseClassmethod with an instance ofSubClass?Thanks!
den-run-ai commentedon Aug 25, 2017
@jaredbroad @mhandschuh @AlexCatarino the issue is much deeper. As a starter take a look at this PR which I gave up on merging:
#217
For more of overloading stuff have a look at this meta-issue (this is one of my frequent nightmares):
#265