Skip to content

PyUnicode_AsUnicode function signature mismatch on UCS2/UCS4 #408

Closed

Description

@vmuriart

Signatures of the functions are different.

UCS2:
internal unsafe static extern char* PyUnicode_AsUnicode(IntPtr ob);

UCS4:
internal unsafe static extern IntPtr PyUnicode_AsUnicode(IntPtr ob);

Leading to weird hacks in the code such as 1 and 2

Consolidate signature to IntPtr and remove PyUnicode_AS_UNICODE which does the same thing.

Activity

  1. self-assigned this
    on Feb 26, 2017
  2. vmuriart commented on Feb 28, 2017

    @vmuriart
    ContributorAuthor

    Closed by #407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions