Repository navigation
xUnit test runner fails to find module dictionary #372
Description
Environment
- Pythonnet version:
v2.2.2 - Python version:
all - Operating System:
Windows
Details
- Describe what you were trying to get done.
Replace nUnit to xUnit framework.
- What commands did you run to trigger this issue? If you can provide a
Minimal, Complete, and Verifiable example
this will help us understand the issue.
Below is one of the tests rewritten for xUnit
using System.Collections.Generic;
using Xunit;
using Python.Runtime;
namespace Python.EmbeddingTest
{
public class PyIterTest
{
[Fact]
public void TestOnPyList()
{
using (Py.GIL())
{
var list = new PyList();
list.Append(new PyString("foo"));
list.Append(new PyString("bar"));
list.Append(new PyString("baz"));
var result = new List<string>();
foreach (PyObject item in list)
{
result.Add(item.ToString());
}
Assert.Equal(3, result.Count);
Assert.Equal("foo", result[0]);
Assert.Equal("bar", result[1]);
Assert.Equal("baz", result[2]);
}
}
}
}- If there was a crash, please include the traceback here.
Error msg: Fatal Python error: PyImport_GetModuleDict: no module dictionary!
Activity
vmuriart commentedon Feb 9, 2017
Submitting this since this is a completely different issue that the ones we saw with
nUnitandmstests. I was testing it as an alternative for #371 and found a different slew of issues.The goal of this issue is to understand why
pythonnetis behaving this way when being run fromxUnit.den-run-ai commentedon Feb 9, 2017
Don't you need to shutdown the interpreter in the teardown?
vmuriart commentedon Feb 10, 2017
failed with and without it. I converted and rewrote the entire test suite and tried it multiple ways, none of them worked. This was just one of the simplest ways to reproduce it
den-run-ai commentedon Feb 10, 2017
@vmuriart did you try xunit locally? with debugger?
den-run-ai commentedon Feb 10, 2017
According to this SO answer, it is likely that some CPython threads are killed during process exit, that's why we get these errors:
http://stackoverflow.com/questions/17679715/fatal-python-error-pyimport-getmoduledict-no-module-dictionary
vmuriart commentedon Feb 10, 2017
Nice find! We still have pending issues w our finalizers. This & the NUnit App unloading are related to it most likely
den-run-ai commentedon Feb 10, 2017
@vmuriart yep, one of my comments in finalizer pull request was ignored (i hope it does not cause deadlocks):
https://github.com/pythonnet/pythonnet/pull/365/files/c954442c3f2ae594ca318f298ebd4607ea7fab3d#r99997577
vmuriart commentedon Feb 10, 2017
Did you hit submit on the review? I don't see any comment, and I been having issues w the review holding my comments until i submit my review
den-run-ai commentedon Feb 10, 2017
vmuriart commentedon Feb 10, 2017
It doesn't show a review or comment from you. Didn't ignore it on purpose.
The commit actually is preventing the lockup that was causing the previous crash. But there is still more work need to properly fix the issue.
vmuriart commentedon Mar 24, 2017
This looks to be yet another issue w
gc. If only 1 test is run, test will run, pass but xUnit will not exit, just hang. If two tests are run, then xUnit will crash and/or hang. This can be similarly reproduced on NUnit by using--dispose-runnersoption.xUnitby default disposes of its objects after every test.NUniton the other hand doesn't really, and--dispose-runnersforces objects to be disposed after being used; meant to be used on system with low resources.filmor commentedon Aug 6, 2021
We don't use xUnit (anymore).