Skip to content

Py_DEBUG vs PYTHON_WITH_PYDEBUG build directives #362

Closed
Closed
Py_DEBUG vs PYTHON_WITH_PYDEBUG build directives#362
Milestone
2.3.0

Description

@vmuriart
vmuriart
opened on Feb 7, 2017

Is there a differences between Py_DEBUG and PYTHON_WITH_DEBUG

Py_DEBUG is the official flags name that Python uses to build Python with debug. But we never define Py_DEBUG at all, only PYTHON_WITH_DEBUG on the setup.py script. Is there a difference I'm overseeing or do they just need renaming?

Activity

  1. vmuriart commented on Feb 7, 2017

    @vmuriart
    vmuriart
    on Feb 7, 2017
    ContributorAuthor

    Just browsed the history and found when they were introduced into runtime.cs atleast (Py_DEBUG is present in other files) Christian introduced Py_DEBUG back in 2004 (035b7ad). @tonyroberts introduced PYTHON_WITH_PYDEBUG on 2014 (5062377) for Python3/Mono compatibility.

    Looks like we just need to rename the remaining Py_DEBUG to PYTHON_WITH_PYDEBUG to close this issue. And/Or add an option to define Py_DEBUG on setup.py for Python 2.7 (since it doesnt have abiflags)

    Does that sound about right @tonyroberts ?

  2. vmuriart
    added this to the 2.3.0 milestone on Mar 3, 2017
  3. vmuriart
    closed this as completedin a14ff14on Mar 3, 2017
  4. yagweb
    added a commit that references this issue on Apr 7, 2017

    Combine Py_DEBUG and PYTHON_WITH_PYDEBUG flags

    1d777d1
  5. AlexCatarino
    added a commit that references this issue on Jun 1, 2017

    Rebase with master (#2)

    1aa6e4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions