make Model2onnx agnostic to the type of model used by tensorflow - #54
Merged
Merged
Conversation
fixing dependency with librosa library
Fix issues with all files in setup.py
… not limit it to .h5 models)
Owner
|
I merge this pull request to develop, later this will be integrated into main branch |
Contributor
Author
|
Any update on this? this was never merged into the main branch as far as I can tell? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Model2onnx expects a file with an extension of "h5" models (HDF5 format), but really there's no reason why this would be dependant on the file extension. This makes Model2onnx agnostic to the file extension (and also the tensorflow actual model type).
This replaces PR #53