Issue python#13020: Fix a reference leak when allocating a structsequence object fails.

pitrou · pitrou · commit 37784ba5c08a · 2012-02-15T02:51:43.000+01:00
Patch by Suman Saha.
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -10,6 +10,9 @@ What's New in Python 3.2.3?
 Core and Builtins
 -----------------
 
+- Issue #13020: Fix a reference leak when allocating a structsequence object
+  fails.  Patch by Suman Saha.
+
 - Issue #13908: Ready types returned from PyType_FromSpec.
 
 - Issue #11235: Fix OverflowError when trying to import a source file whose
diff --git a/Objects/structseq.c b/Objects/structseq.c
@@ -129,6 +129,7 @@ structseq_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
 
     res = (PyStructSequence*) PyStructSequence_New(type);
     if (res == NULL) {
+        Py_DECREF(arg);
         return NULL;
     }
     for (i = 0; i < len; ++i) {

Original file line number	Diff line number	Diff line change
`@@ -129,6 +129,7 @@ structseq_new(PyTypeObject type, PyObject args, PyObject *kwds)`
`129`	`129`
`130`	`130`	`res = (PyStructSequence*) PyStructSequence_New(type);`
`131`	`131`	`if (res == NULL) {`
	`132`	`+ Py_DECREF(arg);`
`132`	`133`	`return NULL;`
`133`	`134`	`}`
`134`	`135`	`for (i = 0; i < len; ++i) {`